Closed
Bug 1280177
Opened 8 years ago
Closed 8 years ago
[devedition theme] window controls in private window missaligned
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | unaffected |
| firefox49 | --- | fixed |
| firefox50 | --- | fixed |
People
(Reporter: metasieben, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
6.73 KB,
image/png
|
Details | |
|
58 bytes,
text/x-review-board-request
|
mstange
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
window controls normal/private window
The OSX window controls on private windows are missaligned, when using the devedition theme in Nightly.
|
Assignee | |
Comment 1•8 years ago
|
||
Using mozregression, it seems this regressed with bug 1275650.
Blocks: 1275650
Status: UNCONFIRMED → NEW
status-firefox48:
--- → unaffected
status-firefox49:
--- → affected
status-firefox50:
--- → affected
Ever confirmed: true
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: regression
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59322/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59322/
Attachment #8762862 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Updated•8 years ago
|
Attachment #8762862 -
Flags: review?(mstange) → review+
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8762862 [details] Bug 1280177 - fix titlebar button position in devedition, https://reviewboard.mozilla.org/r/59322/#review56478
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/61b7d2351dd2 fix titlebar button position in devedition, r=mstange
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/61b7d2351dd2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8762862 [details] Bug 1280177 - fix titlebar button position in devedition, Approval Request Comment [Feature/regressing bug #]: bug 1275650 [User impact if declined]: devedition titlebar buttons look off in private windows [Describe test coverage new/current, TreeHerder]: nope, css-only [Risks and why]: low risk, devedition-only CSS fix [String/UUID change made/needed]: nope.
Attachment #8762862 -
Flags: approval-mozilla-aurora?
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8762862 [details] Bug 1280177 - fix titlebar button position in devedition, css fix for recent regression, ok to uplift!
Attachment #8762862 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 8•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7fb240e0de42
You need to log in
before you can comment on or make changes to this bug.
Description
•