Closed Bug 1280177 Opened 4 years ago Closed 4 years ago

[devedition theme] window controls in private window missaligned

Categories

(Firefox :: Theme, defect)

50 Branch
x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox48 --- unaffected
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: metasieben, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(2 files)

The OSX window controls on private windows are missaligned, when using the devedition theme in Nightly.
Using mozregression, it seems this regressed with bug 1275650.
Blocks: 1275650
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: regression
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #8762862 - Flags: review?(mstange) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/61b7d2351dd2
fix titlebar button position in devedition, r=mstange
https://hg.mozilla.org/mozilla-central/rev/61b7d2351dd2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8762862 [details]
Bug 1280177 - fix titlebar button position in devedition,

Approval Request Comment
[Feature/regressing bug #]: bug 1275650
[User impact if declined]: devedition titlebar buttons look off in private windows
[Describe test coverage new/current, TreeHerder]: nope, css-only
[Risks and why]: low risk, devedition-only CSS fix
[String/UUID change made/needed]: nope.
Attachment #8762862 - Flags: approval-mozilla-aurora?
Comment on attachment 8762862 [details]
Bug 1280177 - fix titlebar button position in devedition,

css fix for recent regression, ok to uplift!
Attachment #8762862 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.