Convert zipwriter/test/unit/test_asyncadd.js to use channel.open2()

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Assignee: nobody → ckerschb
Blocks: 1182535
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Created attachment 8762866 [details] [diff] [review]
bug_1280198_convert_test_asyncadd_open2.patch

Kris, you have been touching that test and you are familiar with our conversion from using open() to using open2(). Not changing any functionality within that test - are you willing to sign off on that change?
Attachment #8762866 - Flags: review?(kmaglione+bmo)
Comment on attachment 8762866 [details] [diff] [review]
bug_1280198_convert_test_asyncadd_open2.patch

Review of attachment 8762866 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

::: modules/libjar/zipwriter/test/unit/test_asyncadd.js
@@ +3,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/.
>   */
>  
>  var Cu = Components.utils;
> +Cu.import("resource://gre/modules/NetUtil.jsm");

The definition of |ioSvc| an also be removed from head_zipwriter.js now.

@@ +79,5 @@
>    stream: function method_stream(entry, source)
>    {
>      zipW.addEntryStream(entry, source.lastModifiedTime * PR_MSEC_PER_SEC,
>                          Ci.nsIZipWriter.COMPRESSION_NONE,
> +                         NetUtil.newChannel({

Nit: The added lines all have an extra leading space.
Attachment #8762866 - Flags: review?(kmaglione+bmo) → review+
Created attachment 8762927 [details] [diff] [review]
bug_1280198_convert_test_asyncadd_open2.patch

Thanks!
Attachment #8762866 - Attachment is obsolete: true
Attachment #8762927 - Flags: review+
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf8d980f3031
Convert zipwriter/test/unit/test_asyncadd.js to use channel.open2() r=kmaglione
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cf8d980f3031
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.