1280354 - New page search regression, cannot use link with "Enter"

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Andrei Petcu]

User Agent: Mozilla/5.0 (Android 5.1.1; Mobile; rv:49.0) Gecko/49.0 Firefox/49.0
Build ID: 20160614004007

Steps to reproduce:

1) open a page
2) Ctrl+F "some link"
3) Hit Enter and jump from one search suggestion to another
4) stop on one search result and click Esc and then Enter


Actual results:

It does not "click" on the page as it used to a few days ago. This changed with the new search highlight.


Expected results:

It should "click" on the selected link.

Comment 1

[Alice0775 White]

Attachment: testcase

STR
1. Open testcase
2. Ctrl+F to open Findbar
3. Type BMO
4. Hit [ESC] key to close Findbar
5. Hit [ENTER] key

Actual Results:
Findbar open

Expected Results:
Navigate to https://bugzilla.mozilla.org/

Comment 2

[B.J. Herbison]

The test case behaves as expected for me, Enter activates the link.

I tested on both Ubuntu and Windows 7.

Comment 3

[Alice0775 White]

(In reply to B.J. Herbison from comment #2)
> The test case behaves as expected for me, Enter activates the link.
> 
> I tested on both Ubuntu and Windows 7.

You should enable e10s

Comment 4

[B.J. Herbison]

(In reply to Alice0775 White from comment #3)
> You should enable e10s

Correctly identified, enabling e10s and the bug appears.

I also noted that in the test case pressing enter not only opens the Find Toolbar but also "erases" the previously found text. See the attached screen shot. (Windows 7. Not tested on Linux.) (I'm mentioning this here, but it might possibly be an effect which occurs in other circumstances.)

Comment 5

[B.J. Herbison]

Attachment: After pressing Enter it appears the found text is erased.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 7

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 8

[Andrew Overholt [:overholt]]

Bulk update to find bar bugs that won't be in 50 (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1279695#c4 and local testing).

Comment 9

[Mike de Boer [:mikedeboer]]

This was fixed in another bug.

Comment 10

[Andrei Petcu]

How can I test? last time I checked the new find in page was disabled in Nightly and the old wan was used.

Comment 11

[Andrei Petcu]

I see the new search was reenabled in Nightly and now the issue is fixed :)

Thank you!

Comment 12

[roxleitan]

Verified as fixed on Nightly 51.0a1, build ID:20160914030200 on Windows 10 X64, Ubuntu 16.04 X64 and Mac OS X 10.11, using https://developer.mozilla.org/en-US/ page and the steps to reproduce from the Description and with testcase from comment 1.