1280367 - cgc-splice-on-arguments.js will permafail when gecko moves to aurora 50

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Carsten Book [:Tomcat]]

from uplift simulations when gecko moves to aurora 50

/home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/splice-on-arguments.js | /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5 (code 3, args "")
INFO stderr 2> /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5
make[1]: *** [check-jit-test] Error 2
make: *** [check-jit-test] Error 2 

https://treeherder.mozilla.org/logviewer.html#?job_id=22439277&repo=try

windows and linux it seems

Comment 1

[Carsten Book [:Tomcat]]

[Tracking Requested - why for this release]:

will fail when gecko moves to 50

Comment 2

[Terrence Cole [:terrence]]

Jan changed where we allocate the arguments object a couple weeks ago, so I'm inclined to blame that instead of CGC. Passing the needinfo.

Comment 3

[Jan de Mooij [:jandem]]

Yeah, the RareArgumentsData class I introduced was buggy with moving GC. I just pushed a fix for that (bug 1280252) to inbound.

Tomcat, can you confirm that commit fixes it?

Comment 4

[Carsten Book [:Tomcat]]

yeah looking into it

Comment 5

[Marcia Knous [:marcia]]

Tracking 50+ for this permafail.

Comment 6

[Marcia Knous [:marcia]]

(In reply to Carsten Book [:Tomcat] from comment #4)
> yeah looking into it

Hello Tomcat - Can we confirm this is fixed? thanks!

Comment 7

[Carsten Book [:Tomcat]]

looks good so far

Comment 8

[Till Schneidereit [:till]]

Marking as fixed based on comment 7.

Comment 9

[Julien Cristau [:jcristau]]

Marking as fixed in 50 per bug 1280252