cgc-splice-on-arguments.js will permafail when gecko moves to aurora 50

RESOLVED FIXED

Status

()

Core
JavaScript Engine: JIT
--
critical
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Tomcat, Unassigned)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox50+ fixed)

Details

(Whiteboard: [needed for gecko 50], URL)

(Reporter)

Description

2 years ago
from uplift simulations when gecko moves to aurora 50

/home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/splice-on-arguments.js | /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5 (code 3, args "")
INFO stderr 2> /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5
make[1]: *** [check-jit-test] Error 2
make: *** [check-jit-test] Error 2 

https://treeherder.mozilla.org/logviewer.html#?job_id=22439277&repo=try

windows and linux it seems
(Reporter)

Comment 1

2 years ago
[Tracking Requested - why for this release]:

will fail when gecko moves to 50
tracking-firefox50: --- → ?
Flags: needinfo?(terrence)
Jan changed where we allocate the arguments object a couple weeks ago, so I'm inclined to blame that instead of CGC. Passing the needinfo.
Flags: needinfo?(terrence) → needinfo?(jdemooij)
Yeah, the RareArgumentsData class I introduced was buggy with moving GC. I just pushed a fix for that (bug 1280252) to inbound.

Tomcat, can you confirm that commit fixes it?
Flags: needinfo?(jdemooij) → needinfo?(cbook)
(Reporter)

Comment 4

2 years ago
yeah looking into it
Flags: needinfo?(cbook)
Tracking 50+ for this permafail.
tracking-firefox50: ? → +
(In reply to Carsten Book [:Tomcat] from comment #4)
> yeah looking into it

Hello Tomcat - Can we confirm this is fixed? thanks!
Flags: needinfo?(cbook)
(Reporter)

Comment 7

a year ago
looks good so far
Flags: needinfo?(cbook)
Marking as fixed based on comment 7.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Marking as fixed in 50 per bug 1280252
status-firefox50: --- → fixed
You need to log in before you can comment on or make changes to this bug.