Closed
Bug 1280367
Opened 8 years ago
Closed 8 years ago
cgc-splice-on-arguments.js will permafail when gecko moves to aurora 50
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
People
(Reporter: cbook, Unassigned)
References
()
Details
(Whiteboard: [needed for gecko 50])
from uplift simulations when gecko moves to aurora 50 /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5 TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/splice-on-arguments.js | /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5 (code 3, args "") INFO stderr 2> /home/worker/workspace/build/src/js/src/jit-test/tests/basic/splice-on-arguments.js:13:1 Error: Assertion failed: got (void 0), expected 5 make[1]: *** [check-jit-test] Error 2 make: *** [check-jit-test] Error 2 https://treeherder.mozilla.org/logviewer.html#?job_id=22439277&repo=try windows and linux it seems
Reporter | ||
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]: will fail when gecko moves to 50
tracking-firefox50:
--- → ?
Flags: needinfo?(terrence)
Comment 2•8 years ago
|
||
Jan changed where we allocate the arguments object a couple weeks ago, so I'm inclined to blame that instead of CGC. Passing the needinfo.
Flags: needinfo?(terrence) → needinfo?(jdemooij)
Comment 3•8 years ago
|
||
Yeah, the RareArgumentsData class I introduced was buggy with moving GC. I just pushed a fix for that (bug 1280252) to inbound. Tomcat, can you confirm that commit fixes it?
Flags: needinfo?(jdemooij) → needinfo?(cbook)
Comment 6•8 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #4) > yeah looking into it Hello Tomcat - Can we confirm this is fixed? thanks!
Flags: needinfo?(cbook)
Comment 8•8 years ago
|
||
Marking as fixed based on comment 7.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•