1280383 - Add an environment variable to have separate content processes for debugging

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[George Wright (:gw280) (needinfo me!)]

It is very useful for developers to be able to have a separate name for both the content and parent processes. Since switching to "firefox.exe for everything", this has regressed our developer experience.

I propose we make it so that if an env var "MOZ_SEPARATE_CHILD_PROCESS" is set, then we launch with the old configuration (firefox.exe & plugin-container.exe) rather than the current status.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Bug-1280383-Enable-separate-content-processes-for-de.patch

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8763043 [details] [diff] [review]
0001-Bug-1280383-Enable-separate-content-processes-for-de.patch

Review of attachment 8763043 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +4983,4 @@
>  
>  void
>  XRE_EnableSameExecutableForContentProc() {
> +  if (!getenv("MOZ_SEPARATE_CHILD_PROCESS")) {

Semi-nit: this should be PR_GetEnv, for thread-safety.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4493d5d209af
Enable separate content processes via envvar, for developer use. - r=ted
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bcd718f4972
Fix EOL whitespace.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4493d5d209af
https://hg.mozilla.org/mozilla-central/rev/5bcd718f4972

Comment 5

[George Wright (:gw280) (needinfo me!)]

Thanks for landing this Jeff. I was on PTO yesterday, hence not being around to do it myself.

Comment 6

[Kelsey Gilbert [:jgilbert]]

(In reply to George Wright (:gw280) (:gwright) from comment #5)
> Thanks for landing this Jeff. I was on PTO yesterday, hence not being around
> to do it myself.

My pleasure!