Add an environment variable to have separate content processes for debugging

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gw280, Assigned: gw280)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

It is very useful for developers to be able to have a separate name for both the content and parent processes. Since switching to "firefox.exe for everything", this has regressed our developer experience.

I propose we make it so that if an env var "MOZ_SEPARATE_CHILD_PROCESS" is set, then we launch with the old configuration (firefox.exe & plugin-container.exe) rather than the current status.
Created attachment 8763043 [details] [diff] [review]
0001-Bug-1280383-Enable-separate-content-processes-for-de.patch
Attachment #8763043 - Flags: review?(ted)
Assignee: nobody → gwright
Comment on attachment 8763043 [details] [diff] [review]
0001-Bug-1280383-Enable-separate-content-processes-for-de.patch

Review of attachment 8763043 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +4983,4 @@
>  
>  void
>  XRE_EnableSameExecutableForContentProc() {
> +  if (!getenv("MOZ_SEPARATE_CHILD_PROCESS")) {

Semi-nit: this should be PR_GetEnv, for thread-safety.
Attachment #8763043 - Flags: review?(ted) → review+
Whiteboard: btpp-active

Comment 3

3 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4493d5d209af
Enable separate content processes via envvar, for developer use. - r=ted
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bcd718f4972
Fix EOL whitespace.

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4493d5d209af
https://hg.mozilla.org/mozilla-central/rev/5bcd718f4972
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Thanks for landing this Jeff. I was on PTO yesterday, hence not being around to do it myself.
(In reply to George Wright (:gw280) (:gwright) from comment #5)
> Thanks for landing this Jeff. I was on PTO yesterday, hence not being around
> to do it myself.

My pleasure!
You need to log in before you can comment on or make changes to this bug.