Merge UI migration steps that try to add bookmarks-menu-button

RESOLVED FIXED in Firefox 50

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8763045 [details] [diff] [review]
patch
Attachment #8763045 - Flags: review?(mak77)
(Assignee)

Updated

2 years ago
Version: 48 Branch → Trunk
Comment on attachment 8763045 [details] [diff] [review]
patch

Review of attachment 8763045 [details] [diff] [review]:
-----------------------------------------------------------------

we should probably have a threshold after which we just remove old UI migrations. Doesn't make sense to keep migrations for versions older than a couple years...
Attachment #8763045 - Flags: review?(mak77) → review+
(Assignee)

Comment 2

2 years ago
(In reply to Marco Bonardo [::mak] from comment #1)
> Comment on attachment 8763045 [details] [diff] [review]
> patch
> 
> Review of attachment 8763045 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> we should probably have a threshold after which we just remove old UI
> migrations. Doesn't make sense to keep migrations for versions older than a
> couple years...

Yes, and I've repeatedly removed old migration steps. Note however that bug 1249608 reduced the risk of keeping old steps around. We still shouldn't keep them around forever though.

Comment 3

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/6b61c987f9ed
Merge UI migration steps that try to add bookmarks-menu-button. r=mak

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6b61c987f9ed
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.