Closed Bug 1280429 Opened 4 years ago Closed 4 years ago

Filter definition uses menulists with separators which are too short

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

Details

(Whiteboard: fixed by bug 1278489)

Attachments

(1 file, 1 obsolete file)

Filter definition uses menulists with separators which are too short:

Tools > Message Filters, New.

Below under "Perform these actions": Both menulists have separators which are too short.
Jörg, the choose folder menulist, the second, is correct. It has icons, but I confirm the first needs fix.
Sure, the short separator is OK for the second one, but then the vertical line is missing. Compare this to, for example, "move message".
Attached patch Bug1280429.patch (obsolete) — Splinter Review
This fixes the the separator lehght and I found on Linux some menupopups like Tags, Priority and Junk had not needed indentation.

This patch needs bug 1278489 applied first.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8763331 - Flags: review?(acelists)
(In reply to Jorg K (GMT+2, PTO during summer, NI me) from comment #2)
> Created attachment 8763081 [details]
> Screenshot showing that there is no vertical line.
> 
> Sure, the short separator is OK for the second one, but then the vertical
> line is missing. Compare this to, for example, "move message".

The vertical line is from native appearance menus. The menupopups are not native. They are white for example and the menus gray.
(In reply to Richard Marti (:Paenglab) from comment #4)
> > Sure, the short separator is OK for the second one, but then the vertical
> > line is missing. Compare this to, for example, "move message".
> 
> The vertical line is from native appearance menus. The menupopups are not
> native. They are white for example and the menus gray.

Yes, but it is a mess in the filter editor, that the first menupopup of the picker is white and flat but the subsequent menupoups coming from menus are gray and 3d relief (and possibly with the vertical lines). I vaguely remember we wanted to fix this somewhere but can't remember if it was successful. That should be discussed in a new bug as it is not straightforward (there are multiple options to do).
Comment on attachment 8763331 [details] [diff] [review]
Bug1280429.patch

I'll try this out, but in the mean time we need to decide what to do with Semankey as I think you do not add the classes to SM (in the preceding bug).

I'm not even sure SM needs these new classes as their themes may work differently.

In worst case adding the calls to the classes here (mailnews file) will have no effect in SM, but fixes TB.
Yes, the background color should be done in a new bug.

This additional classes don't harm SM as they have no rule for this class. For me, the worst case would be, it fixes TB and messes up SM. But as I wrote before, this classes aren't used by SM. If they want, they can add this rules to fix their themes if needed.
Bug 1278489 fixes also this issue.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: fixed by bug 1278489
Comment on attachment 8763331 [details] [diff] [review]
Bug1280429.patch

This is obsolete, right, and no review required?
Attachment #8763331 - Attachment is obsolete: true
Attachment #8763331 - Flags: review?(acelists)
Ah yes, sorry.
You need to log in before you can comment on or make changes to this bug.