1280454 - [XHR2] Not passing the responseXML.lastmodified test.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Thomas Wisniewski]

Firefox presently does not pass the web platform test checking the value of responseXML.lastModified (as in, this blocks bug 918688).

However, the test itself will change (or be removed), so I created this bug as a reminder to check and see what decision was made. See the comments in bug 918773 for more detail.

Comment 1

[Anne (:annevk)]

Thomas, I think the actual issue here is that we attempt to compare it to the Last-Modified header which the server does not set. If we just compare it to Date.now() it seems like that should be fine and will match the specification.

I hadn't realized the test was actually trying to use the Last-Modified header.

(We might want to add a test where the Last-Modified header is set I suppose.)

Comment 2

[Thomas Wisniewski]

Attachment: 1280454-correctly-test-last-modified-time-in-xhr-response-document.diff

Then if I'm not misinterpreting you, this patch should do the trick.

If that's the case, then Firefox already passes both tests.

Comment 3

[Anne (:annevk)]

Yeah, that looks reasonable to me.

Comment 4

[Thomas Wisniewski]

Alright. James, hallvors mentioned in another ticket that you're the one to nudge if a change to the web platform tests should be uplifted. If that's the case, then could you check out the patch in comment 2, and let me know if I can help out any further?

Comment 5

[James Graham [:jgraham]]

Nothing is needed from me if annevk or someone r+'s the patch to land in general.

My main comment is that you are overusing assert_true. Please make better use of assert_equals and assert_greater_than[_equals]. Remember multiple asserts are like && i.e. the test will only pass if they all pass.

Comment 6

[Thomas Wisniewski]

Attachment: 1280454-correctly-test-last-modified-time-in-xhr-response-document.diff

Sure, here's a version that addresses that issue.

Comment 7

[Thomas Wisniewski]

Attachment: 1280454-correctly-test-last-modified-time-in-xhr-response-document.diff

Alright, here's a final version of the patch that we can check in, but I don't have access, so could you check it in for me, James? Carrying over r=annevk.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6a7c43fb847
Correct XHR web platform test to verify that the last-modified time is set correctly on the response document if it is set in the HTTP headers (or not). r=annevk

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6a7c43fb847