Closed Bug 1280476 Opened 4 years ago Closed 4 years ago

Split up test task inheritance tree to cater for non-linux platforms

Categories

(Taskcluster :: Services, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: grenade, Assigned: grenade)

References

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1273549 +++
Assignee: nobody → rthijssen
Status: NEW → ASSIGNED
(In reply to Rob Thijssen (:grenade - GMT) from comment #1)
> Created attachment 8763580 [details]
> Bug 1280476 - Split TC legacy test config (docker/windows); ;
> 
> Review commit: https://reviewboard.mozilla.org/r/59782/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/59782/

Oh boy, this one is going to keep me busy! :D

I'll take a look tomorrow - I'm afraid my day is coming to an end now. Thanks Rob!
Comment on attachment 8763580 [details]
Bug 1280476 - Split TC legacy test config (docker/windows);

https://reviewboard.mozilla.org/r/59782/#review56848

Great job!

nit: can you use `hg mv --after` to track the renames to preserve the history of the files that were renamed (as hg doesn't track this automatically)? If you've done that already (and mozreview just doesn't show it to me) then no worries.

::: taskcluster/ci/legacy/tasks/tests/fx_windows_test_base.yml:29
(Diff revision 1)
> +      -
> +        type: 'directory'
> +        path: 'public\test'
> +        expires: '{{#from_now}}1 year{{/from_now}}'
> +    #features:
> +      #allowPtrace: true

You can remove these commented out lines, there is not support for features in generic worker.
Attachment #8763580 - Flags: review?(pmoore) → review+
Component: Platform and Services → Build Config
Product: Taskcluster → Core
Component: Build Config → Platform and Services
Product: Core → Taskcluster
Sorry, wrong bug! ^^^
Comment on attachment 8763580 [details]
Bug 1280476 - Split TC legacy test config (docker/windows);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59782/diff/1-2/
Attachment #8763580 - Attachment description: Bug 1280476 - Split TC legacy test config (docker/windows); ; → Bug 1280476 - Split TC legacy test config (docker/windows);
Comment on attachment 8763580 [details]
Bug 1280476 - Split TC legacy test config (docker/windows);

https://reviewboard.mozilla.org/r/59782/#review56918

suggestions implemented
Attachment #8763580 - Flags: review+
Attached patch bz1280476.patchSplinter Review
reviewed patch update from reviewboard
Attachment #8763580 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/830b31c9a64b
Split TC legacy test config (docker/windows). r=pmoore
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/830b31c9a64b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Backout by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/40969d155419
Backed out changeset 830b31c9a64b for causing decision task failures
Looks like a conflict between this patch and https://hg.mozilla.org/mozilla-central/rev/f8bee801a2a5 which landed on central in the same merge.
That should do it.
Attachment #8764226 - Flags: review?(rthijssen)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8764226 [details] [diff] [review]
bug1280476_gecko_v1.patch

Review of attachment 8764226 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8764226 - Flags: review?(rthijssen) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/dfd38b2b6778
Split TC legacy test config (docker/windows); r=pmoore
https://hg.mozilla.org/mozilla-central/rev/c9edfe35619f
resolved merge conflict with bug 1280437; r=grenade, a=tomcat
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
No longer blocks: 1285576
Component: Platform and Services → Services
You need to log in before you can comment on or make changes to this bug.