Closed
Bug 1280510
Opened 8 years ago
Closed 8 years ago
Linux does not have a hidpi loading asset
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
There is toolkit/themes/linux/global/icons/loading.png But no hidpi version like osx and windows.
|
Assignee | |
Comment 1•8 years ago
|
||
I'm assuming Stephen is the one to provide this :)
Flags: needinfo?(shorlander)
|
||
Comment 2•8 years ago
|
||
Stephen, this currently means that on hidpi Linux we don't display the orange throbber at all. Can we prioritize getting a hidpi asset for this? Thanks!
|
|
||
Comment 3•8 years ago
|
||
Per IRC, we should just replace the Linux asset with the Windows one for both hidpi and lodpi.
Flags: needinfo?(shorlander)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → eitan
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61866/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61866/
Attachment #8767333 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8767333 [details] Bug 1280510 - Copy hi/lo dpi loading icon from windows to Linux. It looks like the icon is now identical across platforms. Please put it in toolkit/themes/shared/icons/.
Attachment #8767333 -
Flags: review?(gijskruitbosch+bugs) → review-
|
|
||
Comment 6•8 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #5) > Please put it in toolkit/themes/shared/icons/. More precisely, you can just hg move the windows files there.
|
|
||
Updated•8 years ago
|
Component: Tabbed Browser → Theme
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8767333 [details] Bug 1280510 - Copy hi/lo dpi loading icon from windows to Linux. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61866/diff/1-2/
Attachment #8767333 -
Flags: review- → review?(dao+bmo)
|
|
||
Updated•8 years ago
|
Attachment #8767333 -
Flags: review?(dao+bmo) → review+
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62f7f4595c88 Copy hi/lo dpi loading icon from windows to Linux. r=dao
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62f7f4595c88
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in
before you can comment on or make changes to this bug.
Description
•