Closed Bug 1280510 Opened 3 years ago Closed 3 years ago

Linux does not have a hidpi loading asset

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

There is
toolkit/themes/linux/global/icons/loading.png

But no hidpi version like osx and windows.
I'm assuming Stephen is the one to provide this :)
Flags: needinfo?(shorlander)
Blocks: 1282168
Stephen, this currently means that on hidpi Linux we don't display the orange throbber at all. Can we prioritize getting a hidpi asset for this? Thanks!
Per IRC, we should just replace the Linux asset with the Windows one for both hidpi and lodpi.
Flags: needinfo?(shorlander)
Assignee: nobody → eitan
Comment on attachment 8767333 [details]
Bug 1280510 - Copy hi/lo dpi loading icon from windows to Linux.

It looks like the icon is now identical across platforms. Please put it in toolkit/themes/shared/icons/.
Attachment #8767333 - Flags: review?(gijskruitbosch+bugs) → review-
(In reply to Dão Gottwald [:dao] from comment #5)
> Please put it in toolkit/themes/shared/icons/.

More precisely, you can just hg move the windows files there.
Component: Tabbed Browser → Theme
Comment on attachment 8767333 [details]
Bug 1280510 - Copy hi/lo dpi loading icon from windows to Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61866/diff/1-2/
Attachment #8767333 - Flags: review- → review?(dao+bmo)
Attachment #8767333 - Flags: review?(dao+bmo) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f7f4595c88
Copy hi/lo dpi loading icon from windows to Linux. r=dao
Duplicate of this bug: 1258512
https://hg.mozilla.org/mozilla-central/rev/62f7f4595c88
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Blocks: 605245
Depends on: 1318861
You need to log in before you can comment on or make changes to this bug.