Closed
Bug 1280513
Opened 9 years ago
Closed 9 years ago
WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule()
Categories
(Core :: Widget: Win32, defect)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
Details
Attachments
(2 files)
See bug 1280355 for understanding the reason.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59462/
Attachment #8763132 -
Flags: review?(m_kato)
Attachment #8763133 -
Flags: review?(m_kato)
|
|
Assignee | |
Comment 3•9 years ago
|
||
For making WinMouseScrollHandler MOZ_LOG* environment variables aware, WinMouseScrollHandler should use LazyLogModule.
Review commit: https://reviewboard.mozilla.org/r/59464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59464/
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8763132 [details]
Bug 1280513 part.1 Rename LogKeyStateImpl() to MouseScrollHandler::MaybeLogKeyState()
https://reviewboard.mozilla.org/r/59462/#review56568
Attachment #8763132 -
Flags: review?(m_kato) → review+
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8763133 [details]
Bug 1280513 part.2 WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule()
https://reviewboard.mozilla.org/r/59464/#review56570
Attachment #8763133 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27edcbca50af
part.1 Rename LogKeyStateImpl() to MouseScrollHandler::MaybeLogKeyState() r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/84c7d65efcbd
part.2 WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule() r=m_kato
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/27edcbca50af
https://hg.mozilla.org/mozilla-central/rev/84c7d65efcbd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•