WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule()

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(2 attachments)

See bug 1280355 for understanding the reason.
Created attachment 8763132 [details]
Bug 1280513 part.1 Rename LogKeyStateImpl() to MouseScrollHandler::MaybeLogKeyState()

Review commit: https://reviewboard.mozilla.org/r/59462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59462/
Attachment #8763132 - Flags: review?(m_kato)
Attachment #8763133 - Flags: review?(m_kato)
Created attachment 8763133 [details]
Bug 1280513 part.2 WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule()

For making WinMouseScrollHandler MOZ_LOG* environment variables aware, WinMouseScrollHandler should use LazyLogModule.

Review commit: https://reviewboard.mozilla.org/r/59464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59464/
Comment on attachment 8763132 [details]
Bug 1280513 part.1 Rename LogKeyStateImpl() to MouseScrollHandler::MaybeLogKeyState()

https://reviewboard.mozilla.org/r/59462/#review56568
Attachment #8763132 - Flags: review?(m_kato) → review+
Comment on attachment 8763133 [details]
Bug 1280513 part.2 WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule()

https://reviewboard.mozilla.org/r/59464/#review56570
Attachment #8763133 - Flags: review?(m_kato) → review+

Comment 6

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27edcbca50af
part.1 Rename LogKeyStateImpl() to MouseScrollHandler::MaybeLogKeyState() r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/84c7d65efcbd
part.2 WinMouseScrollHandler should use LazyLogModule instead of PR_NewLogModule() r=m_kato

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/27edcbca50af
https://hg.mozilla.org/mozilla-central/rev/84c7d65efcbd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.