Closed Bug 1280609 Opened 4 years ago Closed 4 years ago

Unexplained failures on Intel Gen4 on XP

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
platform-rel --- ?
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: jrmuizel, Assigned: BenWa)

Details

(Whiteboard: [gfx-noted] [platform-rel-Intel])

Attachments

(1 file)

We get some unexplained failures on Intel Gen4 on XP. Here are some examples:
[{'adapter': {u'GPUActive': True,
   u'description': u'Intel(R) Q45/Q43 Express Chipset',
   u'deviceID': u'0x2e12',
   u'driver': u'igxprd32',
   u'driverDate': u'7-29-2008',
   u'driverVersion': u'6.14.10.4973',
   u'subsysID': u'00281b0a',
   u'vendorID': u'0x8086'},
  'application/buildId': u'20160614030210',
  'chip': u'gma4500',
  'clientId': u'2e4f0144-ff4e-4032-b561-9a3ec2a8b805',
  'driverVersion': [6, 14, 10, 4973],
  'environment/build/version': u'50.0a1',
  'environment/system/gfx/adapters': [{u'GPUActive': True,
    u'description': u'Intel(R) Q45/Q43 Express Chipset',
    u'deviceID': u'0x2e12',
    u'driver': u'igxprd32',
    u'driverDate': u'7-29-2008',
    u'driverVersion': u'6.14.10.4973',
    u'subsysID': u'00281b0a',
    u'vendorID': u'0x8086'}],
  'environment/system/gfx/features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'unavailable'}},
  'environment/system/os/name': u'Windows_NT',
  'environment/system/os/servicePackMajor': 3,
  'environment/system/os/servicePackMinor': 0,
  'environment/system/os/version': u'5.1',
  'features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'unavailable'}},
  'gen': u'gen4',
  'payload/keyedHistograms/CANVAS_WEBGL_FAILURE_ID': {u'FEATURE_FAILURE_EGL_LIB_INIT': 3L}},
 {'adapter': {u'GPUActive': True,
   u'description': u'Mobile Intel(R) 4 Series Express Chipset Family',
   u'deviceID': u'0x2a42',
   u'driver': u'igxprd32',
   u'driverDate': u'5-1-2009',
   u'driverVersion': u'6.14.10.5068',
   u'subsysID': u'20e417aa',
   u'vendorID': u'0x8086'},
  'application/buildId': u'20160613030258',
  'chip': u'gma4500hd',
  'clientId': u'70b332c4-ac4f-4185-a585-99041122720d',
  'driverVersion': [6, 14, 10, 5068],
  'environment/build/version': u'50.0a1',
  'environment/system/gfx/adapters': [{u'GPUActive': True,
    u'description': u'Mobile Intel(R) 4 Series Express Chipset Family',
    u'deviceID': u'0x2a42',
    u'driver': u'igxprd32',
    u'driverDate': u'5-1-2009',
    u'driverVersion': u'6.14.10.5068',
    u'subsysID': u'20e417aa',
    u'vendorID': u'0x8086'}],
  'environment/system/gfx/features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'unavailable'}},
  'environment/system/os/name': u'Windows_NT',
  'environment/system/os/servicePackMajor': 3,
  'environment/system/os/servicePackMinor': 0,
  'environment/system/os/version': u'5.1',
  'features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'unavailable'}},
  'gen': u'gen4',
  'payload/keyedHistograms/CANVAS_WEBGL_FAILURE_ID': {u'FEATURE_FAILURE_EGL_LIB_INIT': 4L}},
 {'adapter': {u'GPUActive': True,
   u'description': u'Intel(R) G41 Express Chipset',
   u'deviceID': u'0x2e32',
   u'driver': u'igxprd32',
   u'driverDate': u'6-25-2009',
   u'driverVersion': u'6.14.10.5082',
   u'subsysID': u'00000000',
   u'vendorID': u'0x8086'},
  'application/buildId': u'20160612030220',
  'chip': u'gma4500',
  'clientId': u'e27dbbe6-d3c8-40c4-97f5-71617678d245',
  'driverVersion': [6, 14, 10, 5082],
  'environment/build/version': u'50.0a1',
  'environment/system/gfx/adapters': [{u'GPUActive': True,
    u'description': u'Intel(R) G41 Express Chipset',
    u'deviceID': u'0x2e32',
    u'driver': u'igxprd32',
    u'driverDate': u'6-25-2009',
    u'driverVersion': u'6.14.10.5082',
    u'subsysID': u'00000000',
    u'vendorID': u'0x8086'}],
  'environment/system/gfx/features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'blacklisted'}},
  'environment/system/os/name': u'Windows_NT',
  'environment/system/os/servicePackMajor': 3,
  'environment/system/os/servicePackMinor': 0,
  'environment/system/os/version': u'5.1',
  'features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'blacklisted'}},
  'gen': u'gen4',
  'payload/keyedHistograms/CANVAS_WEBGL_FAILURE_ID': {u'FEATURE_FAILURE_EGL_LIB_INIT': 3L}},
 {'adapter': {u'GPUActive': True,
   u'description': u'Mobile Intel(R) 4 Series Express Chipset Family',
   u'deviceID': u'0x2a42',
   u'driver': u'igxprd32',
   u'driverDate': u'5-1-2009',
   u'driverVersion': u'6.14.10.5068',
   u'subsysID': u'02531025',
   u'vendorID': u'0x8086'},
  'application/buildId': u'20160612030220',
  'chip': u'gma4500hd',
  'clientId': u'3db03e09-a136-47f0-8a3e-a04dd5be8bc5',
  'driverVersion': [6, 14, 10, 5068],
  'environment/build/version': u'50.0a1',
  'environment/system/gfx/adapters': [{u'GPUActive': True,
    u'description': u'Mobile Intel(R) 4 Series Express Chipset Family',
    u'deviceID': u'0x2a42',
    u'driver': u'igxprd32',
    u'driverDate': u'5-1-2009',
    u'driverVersion': u'6.14.10.5068',
    u'subsysID': u'02531025',
    u'vendorID': u'0x8086'}],
  'environment/system/gfx/features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'unavailable'}},
  'environment/system/os/name': u'Windows_NT',
  'environment/system/os/servicePackMajor': 3,
  'environment/system/os/servicePackMinor': 0,
  'environment/system/os/version': u'5.1',
  'features': {u'compositor': u'basic',
   u'd2d': {u'status': u'unavailable', u'version': u'1.1'},
   u'd3d11': {u'status': u'unavailable'}},
  'gen': u'gen4',
  'payload/keyedHistograms/CANVAS_WEBGL_FAILURE_ID': {u'FEATURE_FAILURE_EGL_LIB_INIT': 1L}}]
Sounds like breaking this failure code is the first step?
Assignee: nobody → bgirard
Whiteboard: [gfx-noted]
Whiteboard: [gfx-noted] → [gfx-noted] [platform-rel-Intel]
platform-rel: --- → ?
Comment on attachment 8766837 [details]
Bug 1280609 - Remove FEATURE_FAILURE_EGL_LIB_INIT.

https://reviewboard.mozilla.org/r/61552/#review58438
Attachment #8766837 - Flags: review?(jmuizelaar) → review+
Pushed by b56girard@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2f3a0b0aab55
Remove FEATURE_FAILURE_EGL_LIB_INIT. r=jrmuizel
Comment on attachment 8766837 [details]
Bug 1280609 - Remove FEATURE_FAILURE_EGL_LIB_INIT.

Approval Request Comment
[User impact if declined]: None, will take longer to get telemetry data
[Describe test coverage new/current, TreeHerder]: None, telemetry only change
[Risks and why]: Very low, stop clobbering an error id with a more general one
[String/UUID change made/needed]: None
Attachment #8766837 - Flags: approval-mozilla-aurora?
Comment on attachment 8766837 [details]
Bug 1280609 - Remove FEATURE_FAILURE_EGL_LIB_INIT.

Telemetry fix, aurora-only. OK to land. 
Do we have a way to test/verify the fix? Jeff will you follow up after this lands?
Attachment #8766837 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #6)
> Comment on attachment 8766837 [details]
> Bug 1280609 - Remove FEATURE_FAILURE_EGL_LIB_INIT.
> 
> Telemetry fix, aurora-only. OK to land. 
> Do we have a way to test/verify the fix? Jeff will you follow up after this
> lands?

Yes. I'll check the telemetry to make sure things are sane.
https://hg.mozilla.org/mozilla-central/rev/2f3a0b0aab55
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
I'm not able to cleanly uplift this to aurora, likely because Bug 1279657 has not been uplifted to aurora.


It looks like a simple enough conflict to resolve, but I'm not sure if it'd break things elsewhere...

// Under EGL, on Android, pbuffers are supported fine, though
// often without the ability to texture from them directly.
/*static*/ already_AddRefed<GLContext>
GLContextProviderEGL::CreateOffscreen(const mozilla::gfx::IntSize& size,
                                      const SurfaceCaps& minCaps,
                                      CreateContextFlags flags,
                                      nsACString& aFailureId)
{
    bool forceEnableHardware = bool(flags & CreateContextFlags::FORCE_ENABLE_HARDWARE);
<<<<<<< local
    if (!sEGLLibrary.EnsureInitialized(forceEnableHardware, aFailureId)) { // Needed for IsANGLE().
        aFailureId = NS_LITERAL_CSTRING("FEATURE_FAILURE_EGL_LIB_INIT");
=======
    if (!sEGLLibrary.EnsureInitialized(forceEnableHardware, out_failureId)) { // Needed for IsANGLE().
>>>>>>> graft
        return nullptr;
    }

    bool canOffscreenUseHeadless = true;
    if (sEGLLibrary.IsANGLE()) {
        // ANGLE needs to use PBuffers.
        canOffscreenUseHeadless = false;
    }
Flags: needinfo?(bgirard)
That's fine. I'll land it myself.
Flags: needinfo?(bgirard)
Target Milestone: mozilla50 → mozilla49
You need to log in before you can comment on or make changes to this bug.