1280646 - ui/js/services/pinboard.js's pinJob takes a job, ui/js/services/pinboard.js's unPinJob takes a job id

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

While fixing bug 1256751, I noticed (after five minutes of banging my head against a wall) that pinJob and unPinJob take different arguments.

For consistency's sake, could we make both functions take jobs? We'll need to make sure everything that calls unPinJob[1] passes a job and not an id.

1. https://github.com/mozilla/treeherder/search?utf8=%E2%9C%93&q=unPinJob

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'll do this, but I'll wait for 1256751 to land so I don't midair myself.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4095

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/22ed1d6b361661f328182e2610318c44c42b8a7a
Bug 1280646 - Make unpinJob take a job (#4095)

pinJob takes a job, but unpinJob took a job ID. This makes them
both take a job so they are consistent.