ui/js/services/pinboard.js's pinJob takes a job, ui/js/services/pinboard.js's unPinJob takes a job id

NEW
Unassigned

Status

2 years ago
6 months ago

People

(Reporter: KWierso, Unassigned)

Tracking

Details

(Reporter)

Description

2 years ago
While fixing bug 1256751, I noticed (after five minutes of banging my head against a wall) that pinJob and unPinJob take different arguments.

For consistency's sake, could we make both functions take jobs? We'll need to make sure everything that calls unPinJob[1] passes a job and not an id.

1. https://github.com/mozilla/treeherder/search?utf8=%E2%9C%93&q=unPinJob
(Reporter)

Comment 1

2 years ago
I'll do this, but I'll wait for 1256751 to land so I don't midair myself.
Assignee: nobody → wkocher

Updated

10 months ago
Component: Treeherder → Treeherder: Frontend
Assignee: kwierso → nobody
You need to log in before you can comment on or make changes to this bug.