1280666 - Use modified OverScroller to work around bugs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Chrome already has one of these to fix some API badness related to timestamps, so we can start there.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Allow class annotations to set defaults for members when generating Java bindings

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use StackScroller from Chrome for fling animations

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Expose velocity (speed) from StackScroller and use in APZC

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f13ded95511
Allow class annotations to set defaults for members when generating Java bindings r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab9fc4342f54
Use StackScroller from Chrome for fling animations r=rbarker
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e0bbf386df
Expose velocity (speed) from StackScroller and use in APZC r=rbarker

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f13ded95511
https://hg.mozilla.org/mozilla-central/rev/ab9fc4342f54
https://hg.mozilla.org/mozilla-central/rev/a8e0bbf386df

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Should this be uplifted to 49? Please mark status-firefox49 as wontfix if not, or request approval if you want to uplift.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

We should indeed uplift this to 49.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8763648 [details] [diff] [review]
Allow class annotations to set defaults for members when generating Java bindings

Approval Request Comment
[Feature/regressing bug #]: APZ
[User impact if declined]: Possibly more checkerboarding
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: Low
[String/UUID change made/needed]: none

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

(We'll need all three of these patches for 49)

Comment 10

[Randall Barker [:rbarker]]

Will also need Bug 1284570 or else the Nan issue will return.

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8763648 [details] [diff] [review]
Allow class annotations to set defaults for members when generating Java bindings

Review of attachment 8763648 [details] [diff] [review]:
-----------------------------------------------------------------

This patch may fix the potential checkerboarding issue. Take it in aurora.

Comment 12

[Carsten Book [:Tomcat]]

has problems to apply:

grafting 352104:ab9fc4342f54 "Bug 1280666 - Use StackScroller from Chrome for fling animations r=rbarker"
merging gfx/layers/apz/src/AndroidAPZ.cpp
merging mobile/android/base/moz.build
merging widget/android/GeneratedJNIWrappers.cpp
merging widget/android/GeneratedJNIWrappers.h
warning: conflicts while merging widget/android/GeneratedJNIWrappers.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Tomcats-MacBook-Pro-2:mozilla-central Tomcat$

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Fixed up and pushed to beta

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/d639d45b301a
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/976364bdedb9
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/ffaec482162f