Closed Bug 1280666 Opened 4 years ago Closed 4 years ago

Use modified OverScroller to work around bugs

Categories

(Firefox for Android :: Toolbar, defect, P2)

48 Branch
All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox48 --- wontfix
firefox49 --- fixed
fennec 49+ ---
firefox50 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(3 files)

Chrome already has one of these to fix some API badness related to timestamps, so we can start there.
OS: Unspecified → Android
Priority: -- → P2
Hardware: Unspecified → All
Version: unspecified → 48 Branch
Attachment #8763649 - Flags: review?(rbarker) → review+
Assignee: nobody → snorp
Attachment #8763687 - Flags: review?(rbarker) → review+
Attachment #8763648 - Flags: review?(nchen) → review+
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f13ded95511
Allow class annotations to set defaults for members when generating Java bindings r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab9fc4342f54
Use StackScroller from Chrome for fling animations r=rbarker
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e0bbf386df
Expose velocity (speed) from StackScroller and use in APZC r=rbarker
Should this be uplifted to 49? Please mark status-firefox49 as wontfix if not, or request approval if you want to uplift.
Flags: needinfo?(snorp)
We should indeed uplift this to 49.
tracking-fennec: --- → 49+
Flags: needinfo?(snorp)
Comment on attachment 8763648 [details] [diff] [review]
Allow class annotations to set defaults for members when generating Java bindings

Approval Request Comment
[Feature/regressing bug #]: APZ
[User impact if declined]: Possibly more checkerboarding
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: Low
[String/UUID change made/needed]: none
Attachment #8763648 - Flags: approval-mozilla-aurora?
(We'll need all three of these patches for 49)
Will also need Bug 1284570 or else the Nan issue will return.
Comment on attachment 8763648 [details] [diff] [review]
Allow class annotations to set defaults for members when generating Java bindings

Review of attachment 8763648 [details] [diff] [review]:
-----------------------------------------------------------------

This patch may fix the potential checkerboarding issue. Take it in aurora.
Attachment #8763648 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
has problems to apply:

grafting 352104:ab9fc4342f54 "Bug 1280666 - Use StackScroller from Chrome for fling animations r=rbarker"
merging gfx/layers/apz/src/AndroidAPZ.cpp
merging mobile/android/base/moz.build
merging widget/android/GeneratedJNIWrappers.cpp
merging widget/android/GeneratedJNIWrappers.h
warning: conflicts while merging widget/android/GeneratedJNIWrappers.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Tomcats-MacBook-Pro-2:mozilla-central Tomcat$
Flags: needinfo?(snorp)
Fixed up and pushed to beta
Flags: needinfo?(snorp)
You need to log in before you can comment on or make changes to this bug.