1280725 - Save complete in e10s doesn't work as expected

Status: RESOLVED INCOMPLETE

(Core :: DOM: Serializers, defect, P3)

Description

[Carmelo Leggio]

Attachment: TestPagesElectrolysis.zip

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160617030217

Steps to reproduce:

Tried to save a complete version of a web page (tried with some pages with no luck so far).
I tried both aurora (at the moment of writing 49) and nightly (version 50).


Actual results:

I obtained a partial complete version of the page with some images missing while using FF stable (as of writing 47) I obtain the espected result


Expected results:

I espected to have  a complete version of the page as I obtain on Firefox Stable (at the moment of writing 47). Neither with e10s enabled or disabled is working as espected since some images are missing in the complementary folder.

Comment 1

[Carmelo Leggio]

I attached a zip file containing some web pages (localized in Italian for what is worth, since it's my native language) used as a test bed, saved with FF stable(47) and also with various versions of FF aurora and Nightly.
Since this is a no-go for me (and also for others I suppose) to be able to use Firefox with e10s, please try to fix it as soon as possible, given also I tracked similar bugs but the fundamental problem is as of today still truly unresolved.
Best regards and keep up with your already good work :-)

Comment 2

[Abe - QA (:Abe_LV)]

Hi Carmelo,

Could you try with:
1) safe mode:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

2)fresh profile:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

Comment 3

[Benjamin Smedberg]

Henri, do you know who's responsible for save-as/complete?

Carmelo, can you please provide a specific URL that you tried to save and it failed?

Comment 4

[Abe - QA (:Abe_LV)]

I tested this issue on Ubuntu 14.04 x64 with latest nightly using url: https://support.mozilla.org/en-US/kb/push-notifications-firefox.
But I could not reproduce it. Should have mentioned that in comment 2.

--
Version 	50.0a1
Build ID 	20160621030208
Update Channel 	nightly
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Comment 5

[Carmelo Leggio]

Hi guys, sorry for keeping you waiting. You asked for a link that doesn't perform well apart from the ones contained on the zip file I attached before? There's plenty :-/.
Even the following url I tested a moment ago with a fresh installed and fresh profile of Nightly isn't saved as espected https://support.mozilla.org/en-US/kb/push-notifications-firefox. Others urls I tested:
https://www.mozilla.org/en-US/firefox/nightly/firstrun/;
http://maf.mozdev.org/;
http://www.en.wikipedia.org (pick one, whatever).
I remind you I compared the opened page with the saved one and in the last one (for every site of your choice I suppose) some images or logos are missing :-(.
If you need some more info, just ask.
Best regards

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> Henri, do you know who's responsible for save-as/complete?

I don't. My guess is that it isn't actively owned by anyone in particular these days.

Comment 7

[Andrew Overholt [:overholt]]

I concur with Henri. Let me see what I can do.

Comment 8

[Nika Layzell [:nika] (ni? for response)]

On OS X with release (47.0) I tried to save https://support.mozilla.org/en-US/kb/push-notifications-firefox, and didn't get all of the images. The differences between the outputs of the two saves seems to just be some attribute orderings on some tags.

There is definitely a problem with the file not being saved, but I'm not sure if it's a regression because it doesn't seem to be working in 47 and/or with e10s disabled.

Comment 9

[Andrew Overholt [:overholt]]

It seems this isn't an e10s-related regression.

Carmelo, is the problem that some of the images aren't being saved? Michael told me that the images he's seeing not saved are background images (CSS). That's likely bug 115107 (quite old).

(In reply to Michael Layzell [:mystor] from comment #8)
> seems to just be some attribute orderings on some tags.

That's likely bug 1264270 (fixed in 49).

Comment 10

[Carmelo Leggio]

Maybe you're right Andrew and the bug you mentioned is also presen(115107),but for sure I noticed this Nanjing behaviour for quite some months on FF with Electrolysis and it's a different behaviour conpared with stable versions of FF and I think this one is a different one:-(. Parade take a look at the page contained in the zip file I attached before. On my part asap I'lo take a look at the last bug mentioned and as of now apparently fixed (1264270). Best regards

Comment 11

[Carmelo Leggio]

(In reply to Carmelo Leggio from comment #10)
> Maybe you're right Andrew and the bug you mentioned is also
> presen(115107),but for sure I noticed this Nanjing behaviour for quite some
> months on FF with Electrolysis and it's a different behaviour conpared with
> stable versions of FF and I think this one is a different one:-(. Parade
> take a look at the page contained in the zip file I attached before. On my
> part asap I'lo take a look at the last bug mentioned and as of now
> apparently fixed (1264270). Best regards

Sorry I was writing from my cell. Just in case these are the right words I meant to write :-): Presen -> present;Nanjing -> annoying;parade -> please;

Comment 12

[Andrew Overholt [:overholt]]

Michael was looking earlier and can likely take another look at the attachment you provided, Carmelo. Thanks.

(Carmelo: don't bother with the attribute ordering bug; I'm pretty confident and it feels orthogonal to the issue at hand).

Comment 13

[Nika Layzell [:nika] (ni? for response)]

The immediate examples of missing images which I noticed when looking at the files you attached appeared to be due to the background image problem.

Is there any chance that you could find a page which works in Firefox 47, but doesn't work on nightly for saving, and send me the original page, as well as the result of saving from both 47 and nightly? That would make it much easier for me to reproduce the error.

Comment 14

[Carmelo Leggio]

@Michael Layzell
Hi, as you requested I checked and saved some random pages with FF47(Stable current release) and FF50(Nightly) updated at today date (28 June 2016) and using a fresh profile, I used before FF45ESR because is the default in Debian testing, but the results are the same independently of the version used or the platform. The results are in the attached zip file, in which for convenience I inserted a text file with the URL checked.
I remain at disposition for you all in case you need additional informations.
Best regards

Comment 15

[Carmelo Leggio]

Attachment: New test pages for FF_Nightly with e10s on and off compared with FF47

Comment 16

[Nika Layzell [:nika] (ni? for response)]

That's very strange. I have tried saving a few of the pages you provided with Firefox 47 on both Mac OS X and Ubuntu 16.04, and the resulting files I get seem to be the same as with the nightly: as in many fewer files than when you save these directories with Firefox 47.

Comment 17

[Carmelo Leggio]

Hi I suppose there's no update on the bug given that as of today the situation has not changed.
I attached a new test page saved with Firefox Stable (51.0.1 at the moment) and with Firefox Nightly (54.0a1 at the moment)

Comment 18

[Carmelo Leggio]

Attachment: New test page to follow Nightly development

Comment 19

[Carmelo Leggio]

Hi, this problem affects also Firefox 55 (in beta up to 11th of July): not all images or css files are saved using "Save complete" as I experimented creating a fresh and clean profile :-/

Comment 20

[Andrei Purice]

Hey Carmelo,
Can you still reproduce this issue or should we close it?

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:peterv, since the bug has high severity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 23

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I am going to close this as INCOMPLETE. There was back-n-forth clarification many years ago that the situation was still confusing. Also, our code has changed a lot, especially for Fission.
If you encounter a problem with Save As on a recent release, please file a new bug. Thank you.