Closed Bug 1280729 Opened 3 years ago Closed 3 years ago

Intermittent /browser_markup_tag_edit_04.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox48 unaffected, firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox48 --- unaffected
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: aryx, Assigned: jdescottes)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=30278790&repo=mozilla-inbound

18:09:23     INFO -  8949 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | #pseudo::before is selected after deletion -
18:09:23     INFO -  8950 INFO Check that the node was really removed
18:09:23     INFO -  8951 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | The node can't be found in the page anymore -
18:09:23     INFO -  8952 INFO Undo the deletion to restore the original markup
18:09:23     INFO -  8953 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | The last change in the markup-view can be undone -
18:09:24     INFO -  8954 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | The node is back -
18:09:24     INFO -  8955 INFO Leaving test bound
18:09:25     INFO -  8956 INFO Removing tab.
18:09:25     INFO -  8957 INFO Waiting for event: 'TabClose' on [object XULElement].
18:09:25     INFO -  8958 INFO Got event: 'TabClose' on [object XULElement].
18:09:25     INFO -  8959 INFO Tab removed and finished closing
18:09:25     INFO -  TEST-INFO | started process screentopng
18:09:27     INFO -  TEST-INFO | screentopng: exit 0
18:09:27     INFO -  8960 INFO checking window state
18:09:27     INFO -  8961 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Inspector bug triage, filter on CLIMBING SHOES.
Priority: -- → P2
Looking at successful runs of the same test on Linux platforms, the test always takes around 40 seconds, which is close to the default timeout of 45 seconds. Will split it in 2 tests.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
For the record, the test time initially increased with Bug 1107658, where I added 2 new test cases in the same test.
Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

No activity for a week, forwarding the review.
Attachment #8767945 - Flags: review?(zer0) → review?(bgrinstead)
Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

https://reviewboard.mozilla.org/r/62342/#review60718

::: devtools/client/inspector/markup/test/browser_markup_tag_edit_04-backspace.js:61
(Diff revision 1)
> +  for (let data of TEST_DATA) {
> +    yield checkDeleteAndSelection(inspector, data);
> +  }
> +});
> +
> +function* checkDeleteAndSelection(inspector, {selector, focusedSelector, pseudo}) {

Is this function basically copy/pasted?  I'd suggest to move it to head.js and keep `key` in the destructuring or as an arg to the function
Attachment #8767945 - Flags: review?(bgrinstead)
Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62342/diff/1-2/
Attachment #8767945 - Flags: review?(bgrinstead)
Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

https://reviewboard.mozilla.org/r/62342/#review60748
Attachment #8767945 - Flags: review?(bgrinstead) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/a03a6fd88c3d
split intermittent test browser_markup_tag_edit_04.js;r=bgrins
https://hg.mozilla.org/mozilla-central/rev/a03a6fd88c3d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Depends on: 1287741
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.