1280732 - Relative/alias URLs in SDK context-menu image

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect)

Description

[erosman [:erosman]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

It seems that relative/alias URLs (FF34+) does not work for 'sdk/context-menu' context-menu image while they work for context-menu contentScriptFile.

Alias also works elsewhere like for iconURL in 'sdk/notifications'

https://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/context-menu.js

  image: {
    map: stringOrNull,
    is: ["string", "undefined", "null"],
    ok: function (url) {
      if (!url)
        return true;
      return isValidURI(url);
    },
    msg: "Image URL validation failed"
  }
});


https://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/notifications.js

let { iconURL } = valOpts;
iconURL = iconURL && isLocalURL(iconURL) ? data.url(iconURL) : iconURL;


I imagine it can be easily fixed like 'sdk/notifications'.

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562