1280812 - Funky twisty behavior when selecting tree rows in Sidebar/Library

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P4)

Description

[Stefan [:stefanh]]

Tested with ’mach run’ (= fresh profile), Mac OS X 10.11.5 (trunk build)

1) Launch Nightly
2) Open the sidebar or open the library window
3) Select a tree row with a twisty
—> Note funky behavior, the twisty ”jumps” slightly when it changes to white

If you select a row in the sidebar that doesn’t have a twisty, for example the ”Other Bookmarks” row, it looks like the icon moves a bit (very quickly)

I used mstange’s patch in bug 1223550 (https://bug1223550.bmoattachments.org/attachment.cgi?id=8758884) to investigate and the inverted icons doesn’t load until you select a tree row (don’t ask why..).

Comment 1

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #0)
> and the inverted icons doesn’t load until you select a tree row
> (don’t ask why..).

I guess that wasn't clear (the answer is obvious). The weird thing is that they load even when selecting a row without a twisty.

Comment 2

[:Gijs (he/him)]

Isn't this a gecko (imglib?) bug? Or is Firefox theme doing something wrong that influences the loading of the icons?

Comment 3

[:Gijs (he/him)]

(I guess either way I wouldn't expect the reflow to occur and paint while the icon is loading from chrome:// and for the content to visibly shift about - I don't see this behaviour on 48 beta...)

Comment 4

[Stefan [:stefanh]]

(In reply to :Gijs Kruitbosch from comment #2)
> Isn't this a gecko (imglib?) bug? Or is Firefox theme doing something wrong
> that influences the loading of the icons?

Yeah, probably - I just noticed it when I was testing something and thought it was worth filing a bug.  Maybe it's worth to do a work-around - possibly by pre-loading the inverted icons.

Comment 5

[Stefan [:stefanh]]

I actually see this with 48.0b1 (20160606200529):

1) Launch Firefox with a fresh profile
2) View --> Sidebar: Bookmarks
3) Click the "Other Bookmarks" item at the bottom

--> The Other Bookmarks" icon moves/jumps left/right

Comment 6

[Stefan [:stefanh]]

Attachment: Set width and height for the twisty

Setting the width/height for the twisty seems to make the issue go away. I wonder if the dimensions gets lost for a brief moment when you select the treerow?

Comment 7

[Markus Stange [:mstange]]

I don't know the answer to any of these questions. Sounds like it needs more debugging :)

Comment 8

[Stefan [:stefanh]]

JFTR, I've noticed that I hit this warning when selecting a tree row with a twisty (for the first time, fresh profile):
https://dxr.mozilla.org/mozilla-central/rev/60cc643978c7020926fe4145761e26945fcd5c37/layout/base/nsLayoutUtils.cpp#6764

Comment 9

[Tim Nguyen :ntim]

Hi Stefan, is this still relevant ?

Comment 10

[Stefan [:stefanh]]

Hi Tim,
I still see the warning from nsLayoutUtils.cpp. But the left/right movement is gone. Probably because there's now a width specified for the twisty in toolkit/themes/shared/tree.inc.css

Comment 11

[:Gijs (he/him)]

This has gotten fixed.