1280815 - ./mach mercurial-setup fails with 'abort: %1 is not a valid Win32 application'

Status: RESOLVED FIXED

(Developer Services :: Mercurial: configwizard, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Ran |mach mercurial-setup| on fx-team rev 530e96008b7e. After I decided 'n' on the question to use 'hg wip', the setup stopped with an error:

German:
> abort: %1 ist keine zulõssige Win32-Anwendung

English translation:
> abort: %1 is not a valid Win32 application

Comment 2

[Gregory Szorc [:gps]]

Report in bug 1280022 that this still exists. Can someone please confirm?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Confirming that the issue still exists with
mozilla-central 82e1f1b9c055 tip
mozilla-inbound 7c72118d085a tip

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

I also encountered this with today's m-c. 95ffbc4ff635

Comment 5

[Gregory Szorc [:gps]]

Can someone paste output? I'm mostly interested in the ~50 lines before the error (enough to know what part of the code is throwing the error).

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

$ ./mach mercurial-setup
================================================================================
Ensuring https://hg.mozilla.org/hgcustom/version-control-tools is up to date at c:/Users/Eichelhaeher/.mozbuild\version-control-tools
pulling from https://hg.mozilla.org/hgcustom/version-control-tools
searching for changes
adding changesets
adding manifests
adding file changes
added 10 changesets with 15 changes to 12 files
updating bookmark @
(run 'hg update' to get a working copy)
12 files updated, 0 files merged, 0 files removed, 0 files unresolved
(activating bookmark @)
================================================================================
This wizard will guide you through configuring Mercurial for an optimal
experience contributing to Mozilla projects.

The wizard makes no changes without your permission.

To begin, press the enter/return key.

Enable color output to your terminal (Yn)  y
The "pager" extension transparently redirects command output to a pager
program (like "less") so command output can be more easily consumed
(e.g. output longer than the terminal can be scrolled).

Please select one of the following for configuring pager:

  1. Enable pager and configure with recommended settings (preferred)
  2. Enable pager with default configuration
  3. Don't enable pager

Which option would you like?  3
Newer versions of Mercurial have built-in support for integrating with
filesystem watching services to make common operations faster.

This integration is STRONGLY RECOMMENDED when using the Firefox
repository.

Please upgrade to Mercurial 3.8+ so this feature is available.
Enable logging of commands to help diagnose bugs and performance problems (Yn)  y
It is common to want a quick view of changesets that are in progress.

The ``hg wip`` command provides such a view.

Example Usage:

  $ hg wip
  o   4084:fcfa34d0387b dminor @
  |  mozreview: use repository name when displaying treeherder results (bug 1230548) r=mcote
  | @   4083:786baf6d476a gps
  | |  mozreview: create child review requests from batch API
  | o   4082:3f100fa4a94f gps
  | |  mozreview: copy more read-only processing code; r?smacleod
  | o   4081:939417680cbe gps
  |/   mozreview: add web API to submit an entire series of commits (bug 1229468); r?smacleod

(Not shown are the colors that help denote the state each changeset
is in.)

(Relevant config options: alias.wip, revsetalias.wip, templates.wip)

Would you like to install the `hg wip` alias (Yn)?  n
abort: %1 ist keine zulõssige Win32-Anwendung

"zulõssige" should be "zulässige" but that's a general encoding issue with the command line on Windows and non-ASCII characters.

Comment 7

[Gregory Szorc [:gps]]

I'm relatively confident this is a bug in the configwizard extension.

Please paste output from the following:

  $ hg.exe --traceback --config extensions.cw=~/.mozbuild/version-control-tools/hgext/configwizard configwizard

I'm expecting a traceback to be printed as part of querying the firefoxtree state (after you complete the wip section).

Thank you for your patience to help debug this.

Comment 8

[Gregory Szorc [:gps]]

Actually, now that I think I know what's going on, I'm able to reproduce this.

Comment 9

[Gregory Szorc [:gps]]

Attachment: configwizard: invoke hg.exe on Windows (bug 1280815);

Even if you run hg.exe, sys.argv[0] is reported as "hg." When you
try to execute a "hg" process (a Python script with a shebang),
this fails because it isn't a Windows executable. Work around this
by invoking "hg.exe."

Review commit: https://reviewboard.mozilla.org/r/63256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63256/

Comment 10

[Steven MacLeod [:smacleod]]

Comment on attachment 8769290 [details]
configwizard: invoke hg.exe on Windows (bug 1280815);

https://reviewboard.mozilla.org/r/63256/#review60738

Commit message: "try to execute a "hg" process" s/a/an

Comment 11

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/63256/#review60738

I believe the English rule is to use "an" before words beginning with vowels. Even though "h" sounds like a vowel, "a" should still be used.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ea11abe40486
configwizard: invoke hg.exe on Windows ; r=smacleod

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It depends on the sound, not the letter: https://owl.english.purdue.edu/owl/resource/540/01/
>Another case where this rule applies is when acronyms start with consonant letters but have vowel sounds:
>  An MSDS (material safety data sheet) was used to record the data. An SPCC plan (Spill Prevention Control and Countermeasures plan) will help us prepare for the worst.

Comment 14

[Gregory Szorc [:gps]]

Thanks for the link and for correcting me. In my defense, I can find people who agree with me. It appears my teachers 20+ years ago belonged to an old school way of thinking. (They also told me to put 2 spaces after a period - a practice which I have thoroughly abandoned because it is obviously outdated.)