1280827 - Remove some obsolete OS X version checks in gfx/

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Stefan [:stefanh]]

We don’t support anything < 10.9 now, so run-time checks for pre-lion/Lion can be removed (that’s all I found).

Comment 1

[Stefan [:stefanh]]

Attachment: Remove run-time checks

Comment 2

[Stefan [:stefanh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=532dd490e0f5

Comment 3

[Stefan [:stefanh]]

Comment on attachment 8763403 [details] [diff] [review]
Remove run-time checks

Whoops, just before bedtime I noticed that I missed some stuff - there's a !nsCocoaFeatures::OnMavericksOrLater() check in CompositorOGL.cpp...

Comment 4

[Stefan [:stefanh]]

Attachment: Remove run-time checks, new version

Excluding /harfbuzz and /skia, this should be it.

Comment 5

[Stefan [:stefanh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4c927943d42

Comment 6

[Stefan [:stefanh]]

Attachment: Final version

Sorry - I forgot the includes.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Do you mind waiting on this for another release? I'd rather let our dropping of 10.6 bake a little longer.

Comment 8

[Stefan [:stefanh]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> Do you mind waiting on this for another release? I'd rather let our dropping
> of 10.6 bake a little longer.

Sure but is there any specific reason to wait? I mean, you can't run Firefox on anything below 10.9 in the 49 release and some code specific for 10.6-10.8 have already been removed from the tree in this cycle (mozilla 50).

Comment 9

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #8)
> some code specific for
> 10.6-10.8 have already been removed from the tree in this cycle (mozilla 50).
See for example Bug 1272764 and bug 1279017.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

(In reply to Stefan [:stefanh] from comment #8)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> > Do you mind waiting on this for another release? I'd rather let our dropping
> > of 10.6 bake a little longer.
> 
> Sure but is there any specific reason to wait? I mean, you can't run Firefox
> on anything below 10.9 in the 49 release and some code specific for
> 10.6-10.8 have already been removed from the tree in this cycle (mozilla 50).

No real reason, just being conservative. I could probably easily be convinced to take this sooner.

Comment 11

[Stefan [:stefanh]]

OK, I'll try to convince you :-)

1) Today, dom/media was cleaned up from these functions (https://hg.mozilla.org/mozilla-central/rev/a41833214621). ipc/glue and dom/plugins/ipc have also been fixed. There's only one area except gfx/ that uses these version checks now (toolkit/xre). This bug is the actually the last bug that blocks bug 1282251.

2) We're not updating existing Firefox installs on now-unsupported versions of MacOSX (see bug 1284007, comment #4).

3) There's no point in keeping code specific to 10.6-10.8 in gfx/ when it's not possible to use Firefox on these versions of OS X.

4) gfx/ being one of the last consumers of these functions, fits the conservative approach, but now it's time to move forward :-)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ec1de16b81
Remove some obsolete OS X version checks in gfx/. r=jrmuizel.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5ec1de16b81