Closed
Bug 1280841
Opened 9 years ago
Closed 9 years ago
IonMonkey: MIPS: Fix MacroAssembler::storePtr(ImmGCPtr)
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
Details
Attachments
(1 file)
|
1.52 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Fix asm.js/testHeapAccess.js failure caused by Bug 1204422.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8763419 -
Flags: review?(arai.unmht)
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Tooru Fujisawa [:arai] from comment #2)
> Can you tell me what the actual issue is?
I forgot write a relocation for ImmGCPtr that used by jit code in Bug 1204422.
https://github.com/heiher/gecko-dev/blob/mips-dev/js/src/jit/mips-shared/MacroAssembler-mips-shared.cpp#L21
Flags: needinfo?(r)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8763419 [details] [diff] [review]
0001-Bug-1280841-IonMonkey-MIPS-Fix-MacroAssembler-storeP.patch
Review of attachment 8763419 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks :)
I think now I understand the issue and the patch looks good tho, it would be better forwarding the review.
Attachment #8763419 -
Flags: review?(arai.unmht) → review?(jdemooij)
|
||
Updated•9 years ago
|
Attachment #8763419 -
Flags: review?(jdemooij) → review+
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b860a0926e58
IonMonkey: MIPS: Fix MacroAssembler::storePtr(ImmGCPtr). r=jandem
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•