1280859 - After a lot of items are downloaded, Downloads in Library won't open correctly due to timed out the script

Status: RESOLVED WORKSFORME

(Firefox :: Downloads Panel, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

After I download a lot of items (I confirmed with about 100 items), I cannot open Library from [Tools] -> [Downloads].

I see this error in Browser Console:
> Error: Script terminated by timeout at:
> _updateUI@chrome://browser/content/downloads/allDownloadsViewOverlay.js:275:1
> set sessionDownload@chrome://browser/content/downloads/allDownloadsViewOverlay.js:249:7
> HistoryDownloadElementShell@chrome://browser/content/downloads/allDownloadsViewOverlay.js:201:5
> _addDownloadData@chrome://browser/content/downloads/allDownloadsViewOverlay.js:708:19
> onDownloadAdded@chrome://browser/content/downloads/allDownloadsViewOverlay.js:1122:5
> _updateView/<@resource://app/modules/DownloadsCommon.jsm:867:40
> _updateView@resource://app/modules/DownloadsCommon.jsm:867:5
> addView@resource://app/modules/DownloadsCommon.jsm:837:5
> DownloadsPlacesView@chrome://browser/content/downloads/allDownloadsViewOverlay.js:501:3
> @chrome://browser/content/places/downloadsViewOverlay.xul:22:13
> CA_getContentViewForQueryString@chrome://browser/content/places/places.js:1277:18
> set currentPlace@chrome://browser/content/places/places.js:1332:19
> PO_onPlaceSelected@chrome://browser/content/places/places.js:253:7
> onselect@chrome://browser/content/places/places.xul:1:1
> selectItems@chrome://browser/content/places/tree.xml:671:11
> PO_selectLeftPaneQuery@chrome://browser/content/places/places.js:42:5
> PO_selectLeftPaneContainerByHierarchy@chrome://browser/content/places/places.js:76:15
> PO_init@chrome://browser/content/places/places.js:102:5
> onload@chrome://browser/content/places/places.xul:1:1

Looks like that it tries to initialize all items once and that causes timed out.

For a workaround of bug 1279971, I need to clear downloaded items for avoiding OOM crash but this bug blocks it...

Comment 1

[Andrei Purice]

Hey Masayuki,
Can you still reproduce this issue or should we close it?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'll try to fix it when I'm back my desk.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Although I cannot reproduce this bug with over 300 items, my private addon stopped using data URI because of another issue. Now, it uses blob data as the resouse of each download. Therefore, the footprint becomes much lower. So I'm not sure whether I created the original case or not, but it seems that download manager loads items asynchronously because I see older items not having all data immediately after opening it. So I guess that this has already been fixed.