1280872 - Fix WasmLoop code to use RootedWasmInstanceObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

Apparently the API for wasm::Eval changed to require RootedWasmInstanceObject for the export object. I'll attach a patch that fixes this issue and unbreaks fuzzing builds.

Comment 1

[Christian Holler (:decoder)]

Attachment: Bug 1280872 - Fix WasmLoop code to use RootedWasmInstanceObject.

Review commit: https://reviewboard.mozilla.org/r/59678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59678/

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8763500 [details]
Bug 1280872 - Fix WasmLoop code to use RootedWasmInstanceObject.

https://reviewboard.mozilla.org/r/59678/#review56714

Thanks

::: js/src/shell/js.cpp:5225
(Diff revision 1)
>          Rooted<JSObject*> ret(cx, FileAsTypedArray(cx, filename.ptr()));
>          if (!ret)
>              return false;
>  
>          Rooted<TypedArrayObject*> typedArray(cx, &ret->as<TypedArrayObject>());
> -        RootedObject exportObj(cx);
> +        RootedWasmInstanceObject exportObj(cx);

Can you rename exportObj to instanceObj, please?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de10fb9ec9e5
Fix WasmLoop code to use RootedWasmInstanceObject. r=bbouvier

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de10fb9ec9e5

Comment 5

[Luke Wagner [:luke]]

Sorry; I just noticed I had introduced this bug recently.  While looking at this I was wondering: could we allow WasmLoop to call an exported function by giving WasmLoop an additional parameter which was a callback function that would be passed the exportObj (and then the callback function could invoke any exports)?  Then it seems like we could have an outer loop that generates interesting imports/exports and an inner loop that tries those on different modules.  (Just an idea.)