Closed Bug 1280879 Opened 8 years ago Closed 8 years ago

Permafailure test_about_window.py TestAboutWindow.test_elements | AssertionError: u'' != 'deck' | Firefox-ui-tests bustage due to get_attribute() & get_property() changes

Categories

(Testing :: Firefox UI Tests, defect, P1)

Product:
Testing
Component:
Firefox UI Tests
Version:
Version 3
Type:
defect

Tracking

(firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: whimboo, Assigned: automatedtester)

References

Details

(Keywords: intermittent-failure, regression) 

Our firefox-ui-tests are busted now since the patch on bug 1277090 landed:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Firefox%20UI&filter-tier=2&filter-tier=3&selectedJob=30310056

I have to add that also update tests are affected here and any kind of change to the browser and about window might need backward compatible code.
Maybe the best option would be if we somehow could overlay marionette.get_attribute() so it would fallback to get_property() in case of the attribute not found. Otherwise we would need an if clause for each instance of the above mentioned methods.
David, are you going to work on the fix for those tests? I really don't want to get those failures into the next nighty on mozilla-central tomorrow. It would cause failures all the next 5 days. Thanks!
Flags: needinfo?(dburns)
Priority: -- → P1
I have mostly fixed this but the tests seem super flaky on OSX> If I revert my change I am getting similar failures now so will push to try
Flags: needinfo?(dburns)
Summary: Firefox-ui-tests bustage due to get_attribute() & get_property() changes → Permafailure test_about_window.py TestAboutWindow.test_elements | AssertionError: u'' != 'deck' | Firefox-ui-tests bustage due to get_attribute() & get_property() changes
number one now on orangefactor
Backed out bug 1277090 on m-c, will merge that around to integration branches sometime today.
(In reply to Wes Kocher (:KWierso) from comment #7)
> Backed out bug 1277090 on m-c, will merge that around to integration
> branches sometime today.

hm the tier that was broken was tier-2 so it shouldn't have need a backout per the rules or ?
(In reply to Carsten Book [:Tomcat] from comment #10)
> (In reply to Wes Kocher (:KWierso) from comment #7)
> > Backed out bug 1277090 on m-c, will merge that around to integration
> > branches sometime today.
> 
> hm the tier that was broken was tier-2 so it shouldn't have need a backout
> per the rules or ?

ah ok was with approval from david and disscued on irc
Those failures got fixed with the backout of the patch on bug 1277090 already a while ago.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
status-firefox50: affected → fixed
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.