128094 - closing the dictionary dialog triggers assertion

Status: VERIFIED DUPLICATE of bug 132693

(SeaMonkey :: Composer, defect)

Description

[David Einstein]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.8+)
Gecko/20020223
BuildID:    2002022308

The attached assertion is triggered when the close button is pressed on the
personal dictionary dialog.  Also pressing the x in the upper right hand corner
of the dialog does nothing but report a javascript error "onClose not found" 
the attached patch fixes both.

Reproducible: Always
Steps to Reproduce:
1. Open composer
2. Hit the pell toolbar button
3. Press the edit button on the spellcheck dialog.
4. Press the x in the upper right hand corner of the dictionary dialog
5. Look at the javascript console see the Error.
6. Press the close button

Actual Results:  
after step 4 the dialog persists.
after step 6 the assertion is triggered in a debug build.

Expected Results:  
step4 the dialog should go away.
step5 no error message
step6 no assertion

Comment 1

[David Einstein]

Attachment: Assertion.png

Assertion

Comment 2

[David Einstein]

Attachment: a patch

As advertised, a patch

Comment 3

[sujay]

--> kin

Comment 4

[David Einstein]

Attachment: A better patch

I forgot the keycodes. doh!

Comment 5

[Charles Manske]

Already found and fixed these issues.

*** This bug has been marked as a duplicate of 132693 ***

Comment 6

[sujay]

verified.