|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Created attachment 8763592 [details] Flake8 Errors (as of my patch queue) We should just use the in-tree flake8 job to test taskcluster along with the other directories. Using the design at http://codeverge.com/mozilla.dev.builds/python-flake8-linter-task-live-on-treeherd/2043294
Created attachment 8763722 [details] Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory Review commit: https://reviewboard.mozilla.org/r/59856/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59856/
Comment on attachment 8763722 [details] Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory Not sure how to assign a reviewer through mozreview :(
Comment on attachment 8763722 [details] Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory https://reviewboard.mozilla.org/r/59856/#review56912 I look forward to rebasing over this ;)
Pushed by Callek@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a1748bc8704a Use in-tree linter job to flake8 test taskcluster directory. r=dustin
Did you guys mean to add taskcluster/** to the flake8-gecko task here? https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/branches/base_jobs.yml#736 Keeping in mind the job already runs on **/*.py. The taskcluster line means we run the flake8 job whenever *any* file is changed under taskcluster, even non-python files. I suspect this was an accident, but want to double check.
Yeah, that should be **.py
Which is already included on the first line, so it should just be removed.
Agreed, this was a mistake in my side of things...