Use in-tree linter job to flake8 test taskcluster directory

RESOLVED FIXED

Status

Taskcluster
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Created attachment 8763592 [details]
Flake8 Errors (as of my patch queue)

We should just use the in-tree flake8 job to test taskcluster along with the other directories.

Using the design at http://codeverge.com/mozilla.dev.builds/python-flake8-linter-task-live-on-treeherd/2043294
(Assignee)

Comment 1

a year ago
Created attachment 8763722 [details]
Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory

Review commit: https://reviewboard.mozilla.org/r/59856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59856/
(Assignee)

Comment 2

a year ago
Comment on attachment 8763722 [details]
Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory

Not sure how to assign a reviewer through mozreview :(
Attachment #8763722 - Flags: review?(dustin)
(Assignee)

Comment 3

a year ago
Try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=144d3b0467dd
Comment on attachment 8763722 [details]
Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory

https://reviewboard.mozilla.org/r/59856/#review56912

I look forward to rebasing over this ;)
Attachment #8763722 - Flags: review?(dustin) → review+

Comment 5

a year ago
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1748bc8704a
Use in-tree linter job to flake8 test taskcluster directory. r=dustin

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a1748bc8704a
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Did you guys mean to add taskcluster/** to the flake8-gecko task here?
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/branches/base_jobs.yml#736

Keeping in mind the job already runs on **/*.py. The taskcluster line means we run the flake8 job whenever *any* file is changed under taskcluster, even non-python files. I suspect this was an accident, but want to double check.
Flags: needinfo?(bugspam.Callek)
Yeah, that should be **.py
Which is already included on the first line, so it should just be removed.
(Assignee)

Comment 10

a year ago
Agreed, this was a mistake in my side of things...
Flags: needinfo?(bugspam.Callek)
(Assignee)

Updated

a year ago
Blocks: 1288395
You need to log in before you can comment on or make changes to this bug.