1281032 - Ungrossify skipping of shell browser-chrome tests

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Phil Ringnalda (:philor)]

<philor> oh, how special
<philor> https://dxr.mozilla.org/mozilla-central/source/browser/components/shell/test/browser.ini
<philor> so we fire up a browser instance to run two tests, except there's only one test for not-Linux
<jmaher|afk> heh
<philor> and the one that runs on not-Linux? https://dxr.mozilla.org/mozilla-central/source/browser/components/shell/test/browser_420786.js#75
<philor> IT DOESN'T DO ANYTHING ON NOT-LINUX
<jmaher|afk> philor: can you file a bug to remove that hack and put it in the manifest- then we can put a top level skip-if in the [default] section

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1281032 - skip entire directory on non linux.

Review commit: https://reviewboard.mozilla.org/r/59942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59942/

Comment 2

[Carsten Book [:Tomcat]]

Comment on attachment 8763824 [details]
Bug 1281032 - skip entire directory on non linux.

r+, thanks joel!

Comment 3

[Carsten Book [:Tomcat]]

https://reviewboard.mozilla.org/r/59942/#review56860

thanks joel!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6847131c3c0
skip entire directory on non linux. r=Tomcat

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a6847131c3c0