Closed
Bug 1281066
Opened 9 years ago
Closed 9 years ago
speed up add-new-page operation by fetching metadata separately
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmosedale, Assigned: andreio)
References
Details
(Whiteboard: [akita-beta] [ux-triage])
User Story
Tech checklist * add an UpdatePage action, have the pageStore subscribe to it, and have it use a newly created dataDriver.updatePage method * tear out getPageMetadata code from pageStore.updateRoomInfo and set it aside * have update room info ** dispatch the AddPage action using the already-present thumbnail info (default from favicon) ** put back getPageMetadata, and add a then clause which dispatches updateRoomInfo ** ...
Attachments
(1 file)
In the add-page code that's already in the tree, as well as in the about-to-land bug 1274416, after a page is added, there is a long delay fetching the metadata before it shows up.
We should put the metadata creation directly into the AddPage handler in participantStore after firebase has been updated, or else make it a separate action. Once the metadata is returned we should update both the appropriate store and firebase. This will require a new UpdatePage action.
Note that as part of this, we probably want to make the "Snackbar" actions be named differently (if we want them to even be actions at all; it could be that just exposing the appropriate info in the store will sufficient). Right now, if the UI changes, the action name won't make sense. The UI details should be kept inside the views.
|
||
Comment 1•9 years ago
|
||
This might be too much pre-optimisation, but it might be worth considering if we should get the thumbnail separate to the metadata as well. Depending on the size of the page/thumbnail, I could see this taking a while to generate.
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → andrei.br92
User Story: (updated)
|
||
Comment 2•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8766552 -
Flags: review?(edilee)
Attachment #8766552 -
Flags: review?(b.mcb)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8766552 [details] [review]
[loop] piatra:1281066-add-link > mozilla:akita
Looks good. Thanks for the changes r=me.
Note: Taskcluster is failing and I'm not sure why. Do not merge the PR until Mark takes a look at it
Flags: needinfo?(standard8)
Attachment #8766552 -
Flags: review?(edilee)
Attachment #8766552 -
Flags: review?(b.mcb)
Attachment #8766552 -
Flags: review+
|
|
||
Comment 4•9 years ago
|
||
The functional test failure shown in Taskcluster is bug 1283745. This can be merged.
Flags: needinfo?(standard8)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•