Closed Bug 1281074 Opened 9 years ago Closed 9 years ago

Can no longer build Firefox using the cairo-gtk2 toolkit

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
Unspecified
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1280964

People

(Reporter: wgianopoulos, Unassigned)

References

Details

(Keywords: regression)

I an no longer build Firefox using the cairo-gtk2 toolkit. The errors I get are: 7:01.24 In file included from /home/wag/mozilla/test/widget/gtk/IMContextWrapper.cpp:12:0, 7:01.24 from /home/wag/mozilla/test/fxgtk2-obj/widget/gtk/Unified_cpp_widget_gtk0.cpp:2: 7:01.25 /home/wag/mozilla/test/widget/gtk/nsWindow.h:324:75: error: ‘IntSize’ does not name a type 7:01.25 const IntSize& aSize); 7:01.25 ^~~~~~~ 7:01.25 In file included from /home/wag/mozilla/test/fxgtk2-obj/widget/gtk/Unified_cpp_widget_gtk0.cpp:101:0: 7:01.25 /home/wag/mozilla/test/widget/gtk/nsDragService.cpp: In member function ‘bool nsDragService::SetAlphaPixmap(nsBaseDragService::SourceSurface*, GdkDragContext*, int32_t, int32_t, const nsIntRect&)’: 7:01.25 /home/wag/mozilla/test/widget/gtk/nsDragService.cpp:445:71: error: no matching function for call to ‘mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits>::IntRectTyped(const int&, const int&)’ 7:01.25 dragRect.height)); 7:01.25 ^ 7:01.25 In file included from /home/wag/mozilla/test/fxgtk2-obj/dist/include/nsRect.h:14:0, 7:01.25 from /home/wag/mozilla/test/widget/nsIWidget.h:12, 7:01.25 from /home/wag/mozilla/test/widget/gtk/IMContextWrapper.h:17, 7:01.25 from /home/wag/mozilla/test/widget/gtk/IMContextWrapper.cpp:10, 7:01.25 from /home/wag/mozilla/test/fxgtk2-obj/widget/gtk/Unified_cpp_widget_gtk0.cpp:2: 7:01.25 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:92:5: note: candidate: mozilla::gfx::IntRectTyped<units>::IntRectTyped(int32_t, int32_t, int32_t, int32_t) [with units = mozilla::gfx::UnknownUnits; int32_t = int] 7:01.25 IntRectTyped(int32_t _x, int32_t _y, int32_t _width, int32_t _height) : 7:01.25 ^~~~~~~~~~~~ 7:01.25 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:92:5: note: candidate expects 4 arguments, 2 provided 7:01.25 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:90:5: note: candidate: mozilla::gfx::IntRectTyped<units>::IntRectTyped(const mozilla::gfx::IntPointTyped<units>&, const mozilla::gfx::IntSizeTyped<units>&) [with units = mozilla::gfx::UnknownUnits] 7:01.25 IntRectTyped(const IntPointTyped<units>& aPos, const IntSizeTyped<units>& aSize) : 7:01.25 ^~~~~~~~~~~~ 7:01.25 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:90:5: note: no known conversion for argument 1 from ‘const int’ to ‘const mozilla::gfx::IntPointTyped<mozilla::gfx::UnknownUnits>&’ 7:01.26 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:89:5: note: candidate: mozilla::gfx::IntRectTyped<units>::IntRectTyped() [with units = mozilla::gfx::UnknownUnits] 7:01.26 IntRectTyped() : Super() {} 7:01.26 ^~~~~~~~~~~~ 7:01.26 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:89:5: note: candidate expects 0 arguments, 2 provided 7:01.26 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:81:8: note: candidate: constexpr mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits>::IntRectTyped(const mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits>&) 7:01.26 struct IntRectTyped : 7:01.27 ^~~~~~~~~~~~ 7:01.27 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:81:8: note: candidate expects 1 argument, 2 provided 7:01.27 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:81:8: note: candidate: constexpr mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits>::IntRectTyped(mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits>&&) 7:01.27 /home/wag/mozilla/test/fxgtk2-obj/dist/include/mozilla/gfx/Rect.h:81:8: note: candidate expects 1 argument, 2 provided 7:01.27 7:01.27 In the directory /home/wag/mozilla/test/fxgtk2-obj/widget/gtk 7:01.27 The following command failed to execute properly: 7:01.27 /usr/lib64/ccache/g++ -std=gnu++11 -o Unified_cpp_widget_gtk0.o -c -I/home/wag/mozilla/test/fxgtk2-obj/dist/stl_wrappers -I/home/wag/mozilla/test/fxgtk2-obj/dist/system_wrappers -include /home/wag/mozilla/test/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DCAIRO_GFX -DMOZ_APP_NAME="firefox" -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/wag/mozilla/test/widget/gtk -I/home/wag/mozilla/test/fxgtk2-obj/widget/gtk -I/home/wag/mozilla/test/fxgtk2-obj/ipc/ipdl/_ipdlheaders -I/home/wag/mozilla/test/ipc/chromium/src -I/home/wag/mozilla/test/ipc/glue -I/home/wag/mozilla/test/layout/generic -I/home/wag/mozilla/test/layout/xul -I/home/wag/mozilla/test/other-licenses/atk-1.0 -I/home/wag/mozilla/test/widget -I/home/wag/mozilla/test/widget/x11 -I/home/wag/mozilla/test/fxgtk2-obj/dist/include -I/home/wag/mozilla/test/fxgtk2-obj/dist/include/nspr -I/home/wag/mozilla/test/fxgtk2-obj/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /home/wag/mozilla/test/fxgtk2-obj/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_widget_gtk0.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++14-compat -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -DHAVE_USR_LIB64_DIR -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fomit-frame-pointer -I/home/wag/mozilla/test/fxgtk2-obj/dist/include/cairo -I/home/wag/mozilla/test/widget/gtk/compat -pthread -I/usr/include/gtk-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wno-error=shadow /home/wag/mozilla/test/fxgtk2-obj/widget/gtk/Unified_cpp_widget_gtk0.cpp 7:01.27 /home/wag/mozilla/test/config/rules.mk:934: recipe for target 'Unified_cpp_widget_gtk0.o' failed 7:01.27 gmake[5]: *** [Unified_cpp_widget_gtk0.o] Error 1 7:01.27 gmake[5]: *** Waiting for unfinished jobs.... 7:04.91 In file included from /home/wag/mozilla/test/widget/gtk/nsWindow.cpp:8:0: 7:04.91 /home/wag/mozilla/test/widget/gtk/nsWindow.h:324:75: error: ‘IntSize’ does not name a type 7:04.92 const IntSize& aSize); 7:04.92 ^~~~~~~ 7:04.92 /home/wag/mozilla/test/widget/gtk/nsWindow.cpp:6467:1: error: prototype for ‘already_AddRefed<mozilla::gfx::DrawTarget> nsWindow::GetDrawTargetForGdkDrawable(GdkDrawable*, const IntSize&)’ does not match any in class ‘nsWindow’ 7:04.92 nsWindow::GetDrawTargetForGdkDrawable(GdkDrawable* aDrawable, 7:04.92 ^~~~~~~~ 7:04.92 In file included from /home/wag/mozilla/test/widget/gtk/nsWindow.cpp:8:0: 7:04.92 /home/wag/mozilla/test/widget/gtk/nsWindow.h:323:41: error: candidate is: static already_AddRefed<mozilla::gfx::DrawTarget> nsWindow::GetDrawTargetForGdkDrawable(GdkDrawable*, const int&) 7:04.92 static already_AddRefed<DrawTarget> GetDrawTargetForGdkDrawable(GdkDrawable* aDrawable, 7:04.92 ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 7:04.92 7:04.92 In the directory /home/wag/mozilla/test/fxgtk2-obj/widget/gtk 7:04.92 The following command failed to execute properly: 7:04.93 /usr/lib64/ccache/g++ -std=gnu++11 -o nsWindow.o -c -I/home/wag/mozilla/test/fxgtk2-obj/dist/stl_wrappers -I/home/wag/mozilla/test/fxgtk2-obj/dist/system_wrappers -include /home/wag/mozilla/test/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DCAIRO_GFX -DMOZ_APP_NAME="firefox" -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/wag/mozilla/test/widget/gtk -I/home/wag/mozilla/test/fxgtk2-obj/widget/gtk -I/home/wag/mozilla/test/fxgtk2-obj/ipc/ipdl/_ipdlheaders -I/home/wag/mozilla/test/ipc/chromium/src -I/home/wag/mozilla/test/ipc/glue -I/home/wag/mozilla/test/layout/generic -I/home/wag/mozilla/test/layout/xul -I/home/wag/mozilla/test/other-licenses/atk-1.0 -I/home/wag/mozilla/test/widget -I/home/wag/mozilla/test/widget/x11 -I/home/wag/mozilla/test/fxgtk2-obj/dist/include -I/home/wag/mozilla/test/fxgtk2-obj/dist/include/nspr -I/home/wag/mozilla/test/fxgtk2-obj/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /home/wag/mozilla/test/fxgtk2-obj/mozilla-config.h -MD -MP -MF .deps/nsWindow.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++14-compat -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -DHAVE_USR_LIB64_DIR -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fomit-frame-pointer -I/home/wag/mozilla/test/fxgtk2-obj/dist/include/cairo -I/home/wag/mozilla/test/widget/gtk/compat -pthread -I/usr/include/gtk-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wno-error=shadow /home/wag/mozilla/test/widget/gtk/nsWindow.cpp 7:04.93 /home/wag/mozilla/test/config/rules.mk:934: recipe for target 'nsWindow.o' failed 7:04.93 gmake[5]: *** [nsWindow.o] Error 1 7:04.93 /home/wag/mozilla/test/config/recurse.mk:71: recipe for target 'widget/gtk/target' failed 7:04.93 gmake[4]: *** [widget/gtk/target] Error 2
(In reply to Karl Tomlinson (ni?:karlt) from comment #1) > Does https://hg.mozilla.org/integration/mozilla-inbound/rev/72d118d37454 > work for you? That looks like it should work.
(In reply to Karl Tomlinson (ni?:karlt) from comment #1) > Does https://hg.mozilla.org/integration/mozilla-inbound/rev/72d118d37454 > work for you? And I just verified that does fix my issues.
Thanks.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Clearing affected for 50 since the dupe is tracked there.
status-firefox50: affected → ---
You need to log in before you can comment on or make changes to this bug.