1281122 - Eyedropper is not updating when switching to a different tab or reloading

Status: RESOLVED DUPLICATE of bug 1262439

(DevTools :: General, defect)

Description

[niels.breuker]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160620030215

Steps to reproduce:

First I activated the eyedropper. Then I reloaded the tab/switched to a different tab using ctrl + tab.

You can use the website I made where I found the issue: http://javascript.nilspace.nl/Cuberite/GrownVisualizer/index.html


Actual results:

The eyedropper still showed the previous colors


Expected results:

The colors shown by the eyedropper should update when reloading or switching tabs.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Confirmed on 47 and 50. Patrick, does it fall into your bucket?

Comment 2

[Patrick Brosset <:pbro>]

(In reply to Pascal Chevrel:pascalc from comment #1)
> Confirmed on 47 and 50. Patrick, does it fall into your bucket?
Yes it does, thanks for triaging it.

(In reply to niels.breuker from comment #0)
> The eyedropper still showed the previous colors
Indeed, the eyedropper only samples the colors from the page it was started on. That's how it's always been. Unfortunately, we didn't do a good job at letting users know. We should either disable the eyedropper when the selected tab changes, or when the page navigates. Or we should re-sample the new colors so the eyedropper seamlessly works with the new tab or tab content.

Now, it turns out that for other reasons, we are rewriting the eyedropper. And this rewrite is going to make the eyedropper "part" of the current tab's content, meaning that if you switch to another tab, the eyedropper won't be available there. And if you reload or navigate, the eyedropper will go away.

This is going to be done in bug 1262439. So, as soon as it lands, this bug will become invalid, and since it is quite close from landing, I think we should just close this as a duplicate rather than spend time fixing it.