[linux] Washed out download protection icons

NEW
Unassigned

Status

()

Firefox
Downloads Panel
P2
normal
2 years ago
2 years ago

People

(Reporter: bogdan_maris, Unassigned)

Tracking

Trunk
All
Linux
Points:
---

Firefox Tracking Flags

(firefox47 unaffected, firefox48 affected, firefox49 affected, firefox50 unaffected)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8763844 [details]
Screenshot showing the issue

[Affected versions]:
- Firefox 48 beta 2
- latest Developer Edition 49.0a2

[Unaffected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Ubuntu 16.04 32-bit

[Steps to reproduce]:
1. Start Firefox with clean profile
2. Visit http://testsafebrowsing.appspot.com/
3. Click on item #2 and #5 and save/open files
4. Click Download icon

[Expected result]:
- Red and blue icons are properly displayed

[Actual result]:
- Red and blue icons are washed out

[Regression range]:
- Don't quite know if this is a regression but first Aurora build affected is 48.0a2. Will investigate further.

[Additional notes]:
- Screencast showing the issue attached.
(Reporter)

Comment 1

2 years ago
I was able to track down a regression here and it lead to this:

Last good revision: fc15477ce628599519cb0055f52cc195d640dc94
First bad revision: 37f04460ddb76d6ef4e7c32a8a6b2fbc44cb8776
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fc15477ce628599519cb0055f52cc195d640dc94&tochange=37f04460ddb76d6ef4e7c32a8a6b2fbc44cb8776

a36e52a4543d	Paolo Amadini — Bug 1265358 - Enable blocking of uncommon downloads. r=gcp
f36212ee8d4a	Paolo Amadini — Bug 1265359 - Enable blocking of potentially unwanted downloads. r=gcp
(Reporter)

Comment 2

2 years ago
So this is not a regression, it was introduced while enabling blocking unwanted and uncommon downloads.
Bug 1265341 made the icons look nice. Paolo, do you think we should uplift it or live with the lo-dpi icons for 48 & 49?
Flags: needinfo?(paolo.mozmail)

Comment 4

2 years ago
This affects a very small number of users, those on Linux encountering a blocked download. Given that the styling changes from bug 1265341 also have some risk of visual regressions on less common platforms, I'm tempted to say that we shouldn't uplift to Beta, although we could consider Developer Edition. Jonathan, what do you think?
Flags: needinfo?(paolo.mozmail) → needinfo?(jkt)
I'm not entirely sure on the risks to other platforms, but certainly there is a possibility. This is how the icons looked to me when I tested in Ubuntu and my patch changes this. 
I suspect dev edition uplift is potentially a safer bet though.
Maybe checking all platforms with mozscreenshots is worth doing first though?
Flags: needinfo?(jkt)
Let's decide in the team meeting.
Whiteboard: [fxprivacy][triage]
Not for beta. For Aurora DevEdition. Thank you.
Whiteboard: [fxprivacy][triage] → [fxprivacy]

Updated

2 years ago
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.