1281191 - Re-up expiring WEB_NOTIFICATION_* telemetry probes

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Chris H-C :chutten]

Some WEB_NOTIFICATION_* telemetry probes are expiring real soon now [1].

:njn advocates for extending their lives while we continue to invest in this space. If so, the expires_in_version will need to be bumped and a new Data Review procured (f? from :bsmedberg on the patch).

[1]: https://mail.mozilla.org/pipermail/firefox-dev/2016-June/004375.html

Comment 1

[Andrew Overholt [:overholt]]

William, can you take this?

Comment 3

[William Chen [:wchen]]

We need to figure out which probes we still want to use. This issue will be brought up with the push team tomorrow.

Comment 4

[Edwin Wong [:edwong]]

:clarkbw to follow up

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Yes, we definitely need the opt-out metrics to be extended to match the other push metrics (at least 55).  I can't speak for any of the other metrics.

Comment 6

[Andrew Overholt [:overholt]]

Attachment: re-up notifications telemetry

Comment 7

[Andrew Overholt [:overholt]]

Comment on attachment 8768483 [details] [diff] [review]
re-up notifications telemetry

Bryan would like at least:

WEB_NOTIFICATION_CLICKED
WEB_NOTIFICATION_PERMISSIONS
WEB_NOTIFICATION_SHOWN

re-upped to 55. Like this?

Comment 8

[Chris H-C :chutten]

Like that, yes. Remember to get an f+ from bsmedberg after you get your r+ but before you land. (To make things go smoothly, take a look at https://wiki.mozilla.org/Firefox/Data_Collection to make sure the necessary questions have been answered)

Would you also be willing to remove the remaining expiring probes? (no data review needed for that)

Comment 9

[William Chen [:wchen]]

Comment on attachment 8768483 [details] [diff] [review]
re-up notifications telemetry

Review of attachment 8768483 [details] [diff] [review]:
-----------------------------------------------------------------

Data review: The notification probes are useful to determine the shape of the push funnel (granting permission > receiving a push notification > showing notification > clicking notification). The version is being bumped to 55 to match other push probes. The push team will be looking at the data collected (with clarkbw being the responsible individual).

Comment 10

[Benjamin Smedberg]

Comment on attachment 8768483 [details] [diff] [review]
re-up notifications telemetry

Do you have an example of the analysis that you've already done on the push funnel? That's the kind of thing that we want to publicly share and blog about to show our telemetry systems in action.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

We've only just recently changed the probes we need to be opt-out, we are planning on sharing these metrics once they are in a stable state. For example bug 1269466 is creating an engagement metric for push based partially off these funnel probes.

Comment 12

[Benjamin Smedberg]

You've had them on beta for a while though, right? Do you have beta-specific data to prove that the data is sane and useful?

Comment 13

[Andrew Overholt [:overholt]]

(In reply to Chris H-C :chutten from comment #8)
> Would you also be willing to remove the remaining expiring probes? (no data
> review needed for that)

I'll defer to Bryan for that but I'm happy to write a patch full of -s.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Let me defer to javaun about removing the other probes.  I'm assuming the control centre team implemented those but I'm not sure if they still require them.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbcb9fbfcb13
Re-up opt-out Notifications telemetry. r=wchen

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbcb9fbfcb13

Comment 17

[Nicholas Nethercote [inactive]]

> :njn advocates for extending their lives while we continue to invest in this
> space.

It was nalexander, not me :)