Closed Bug 1281191 Opened 4 years ago Closed 4 years ago

Re-up expiring WEB_NOTIFICATION_* telemetry probes

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: chutten, Assigned: overholt, NeedInfo)

References

Details

Attachments

(1 file)

Some WEB_NOTIFICATION_* telemetry probes are expiring real soon now [1].

:njn advocates for extending their lives while we continue to invest in this space. If so, the expires_in_version will need to be bumped and a new Data Review procured (f? from :bsmedberg on the patch).

[1]: https://mail.mozilla.org/pipermail/firefox-dev/2016-June/004375.html
William, can you take this?
Flags: needinfo?(wchen)
Duplicate of this bug: 1279113
We need to figure out which probes we still want to use. This issue will be brought up with the push team tomorrow.
Flags: needinfo?(wchen)
:clarkbw to follow up
Flags: needinfo?(clarkbw)
Whiteboard: btpp-followup-2016-07-05
Yes, we definitely need the opt-out metrics to be extended to match the other push metrics (at least 55).  I can't speak for any of the other metrics.
Flags: needinfo?(clarkbw)
Comment on attachment 8768483 [details] [diff] [review]
re-up notifications telemetry

Bryan would like at least:

WEB_NOTIFICATION_CLICKED
WEB_NOTIFICATION_PERMISSIONS
WEB_NOTIFICATION_SHOWN

re-upped to 55. Like this?
Attachment #8768483 - Flags: review?(wchen)
Like that, yes. Remember to get an f+ from bsmedberg after you get your r+ but before you land. (To make things go smoothly, take a look at https://wiki.mozilla.org/Firefox/Data_Collection to make sure the necessary questions have been answered)

Would you also be willing to remove the remaining expiring probes? (no data review needed for that)
Comment on attachment 8768483 [details] [diff] [review]
re-up notifications telemetry

Review of attachment 8768483 [details] [diff] [review]:
-----------------------------------------------------------------

Data review: The notification probes are useful to determine the shape of the push funnel (granting permission > receiving a push notification > showing notification > clicking notification). The version is being bumped to 55 to match other push probes. The push team will be looking at the data collected (with clarkbw being the responsible individual).
Attachment #8768483 - Flags: review?(wchen)
Attachment #8768483 - Flags: review+
Attachment #8768483 - Flags: feedback?(benjamin)
Comment on attachment 8768483 [details] [diff] [review]
re-up notifications telemetry

Do you have an example of the analysis that you've already done on the push funnel? That's the kind of thing that we want to publicly share and blog about to show our telemetry systems in action.
Flags: needinfo?(clarkbw)
Attachment #8768483 - Flags: feedback?(benjamin) → feedback+
We've only just recently changed the probes we need to be opt-out, we are planning on sharing these metrics once they are in a stable state. For example bug 1269466 is creating an engagement metric for push based partially off these funnel probes.
Flags: needinfo?(clarkbw)
You've had them on beta for a while though, right? Do you have beta-specific data to prove that the data is sane and useful?
(In reply to Chris H-C :chutten from comment #8)
> Would you also be willing to remove the remaining expiring probes? (no data
> review needed for that)

I'll defer to Bryan for that but I'm happy to write a patch full of -s.
Assignee: nobody → overholt
Keywords: checkin-needed
Whiteboard: btpp-followup-2016-07-05
Let me defer to javaun about removing the other probes.  I'm assuming the control centre team implemented those but I'm not sure if they still require them.
Flags: needinfo?(jmoradi)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbcb9fbfcb13
Re-up opt-out Notifications telemetry. r=wchen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cbcb9fbfcb13
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
> :njn advocates for extending their lives while we continue to invest in this
> space.

It was nalexander, not me :)
You need to log in before you can comment on or make changes to this bug.