Closed Bug 1281252 Opened 7 years ago Closed 7 years ago

Add extra recording for when media is subscribed to successfully, and exactly which subscriber exceptions are happening on

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

[loop] Standard8:stats-additions > mozilla:master
40 bytes, text/x-github-pull-request
dmosedale
: review+
Details | Review 
Currently we don't log to loop-server when we actually have received a media stream - we only log the fact that the stream has been created. This leaves us in a place where we don't know if the WebRTC connection has fully completed or not.

Additionally, there's no distinction with exceptions raised on the a/v streams versus the screen sharing streams.

We need to fix this to help our logging and understand the issues with our rates better.
Attachment #8763985 - Flags: review?(edilee)
Attachment #8763985 - Flags: review?(dmose)
Attachment #8763985 - Flags: review?(dcritchley)
Attachment #8763985 - Flags: review?(edilee)
Attachment #8763985 - Flags: review?(dcritchley)
Comment on attachment 8763985 [details] [review]
[loop] Standard8:stats-additions > mozilla:master

r=dmose, with any comments addressed as you feel appropriate.
Attachment #8763985 - Flags: review?(dmose) → review+
https://github.com/mozilla/loop/commit/d572b37f87b3e3f2f95a6de6378d014483d7ad77
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1281619
You need to log in before you can comment on or make changes to this bug.