Created attachment 8763983 [details] [diff] [review] Patch TSan reports a race in LIRGenerator::visitNewCallObject for the templateObject->isSingleton() check there. We can fix that by renaming MNewRunOnceCallObject to MNewSingletonCallObject, and then using it for singleton call objects as well. LIR/codegen is exactly the same, but this fixes the race and is a nice cleanup anyway.
Attachment #8763983 - Flags: review?(bhackett1024)
Attachment #8763983 - Flags: review?(bhackett1024) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1332761564 Clean up MNewCallObject a bit and fix a TSan race. r=bhackett
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.