Some MNewCallObject cleanup and TSan fixes

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8763983 [details] [diff] [review]
Patch

TSan reports a race in LIRGenerator::visitNewCallObject for the templateObject->isSingleton() check there.

We can fix that by renaming MNewRunOnceCallObject to MNewSingletonCallObject, and then using it for singleton call objects as well.

LIR/codegen is exactly the same, but this fixes the race and is a nice cleanup anyway.
Attachment #8763983 - Flags: review?(bhackett1024)
Attachment #8763983 - Flags: review?(bhackett1024) → review+

Comment 1

2 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1332761564
Clean up MNewCallObject a bit and fix a TSan race. r=bhackett

Comment 2

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7a1332761564
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.