Closed
Bug 1281253
Opened 8 years ago
Closed 8 years ago
Some MNewCallObject cleanup and TSan fixes
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
8.01 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
TSan reports a race in LIRGenerator::visitNewCallObject for the templateObject->isSingleton() check there. We can fix that by renaming MNewRunOnceCallObject to MNewSingletonCallObject, and then using it for singleton call objects as well. LIR/codegen is exactly the same, but this fixes the race and is a nice cleanup anyway.
Attachment #8763983 -
Flags: review?(bhackett1024)
|
||
Updated•8 years ago
|
Attachment #8763983 -
Flags: review?(bhackett1024) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1332761564 Clean up MNewCallObject a bit and fix a TSan race. r=bhackett
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7a1332761564
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•