Closed
Bug 1281276
Opened 9 years ago
Closed 9 years ago
Drop the concept of caller language from XPCCallContext
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Whiteboard: btpp-active)
Attachments
(5 files)
5.74 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
1.17 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
1.68 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
4.91 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
28.79 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
We thread this all through stuff, but only use it for one assert. We can nix this, I think.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8764025 -
Flags: review?(bobbyholley)
![]() |
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8764028 -
Flags: review?(bobbyholley)
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8764029 -
Flags: review?(bobbyholley)
![]() |
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8764030 -
Flags: review?(bobbyholley)
![]() |
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8764031 -
Flags: review?(bobbyholley)
Updated•9 years ago
|
Attachment #8764025 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Attachment #8764028 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Attachment #8764029 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Attachment #8764030 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Attachment #8764031 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Whiteboard: btpp-active
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60fb7c5abb3f
part 1. Eliminate XPCCallContext's mCallerLanguage member. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/e304e87eebad
part 2. Eliminate the unused XPCContext::CallerTypeIsNative/CallerTypeIsKnown methods. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc7b73290ba
part 3. Drop the one place that uses XPCContext::CallerTypeIsJavaScript() (an assertion). r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3da1bcf7194
part 4. Get rid of XPCContext's mCallingLangType member. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/81fe29f830af
part 5. Get rid of the LangType argument of the XPCCallContext constructor and the now-dead language type enums. r=bholley
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60fb7c5abb3f
https://hg.mozilla.org/mozilla-central/rev/e304e87eebad
https://hg.mozilla.org/mozilla-central/rev/ffc7b73290ba
https://hg.mozilla.org/mozilla-central/rev/c3da1bcf7194
https://hg.mozilla.org/mozilla-central/rev/81fe29f830af
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•