Closed Bug 1281276 Opened 4 years ago Closed 4 years ago

Drop the concept of caller language from XPCCallContext

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Whiteboard: btpp-active)

Attachments

(5 files)

We thread this all through stuff, but only use it for one assert.  We can nix this, I think.
Attachment #8764025 - Flags: review?(bobbyholley) → review+
Attachment #8764028 - Flags: review?(bobbyholley) → review+
Attachment #8764029 - Flags: review?(bobbyholley) → review+
Attachment #8764030 - Flags: review?(bobbyholley) → review+
Attachment #8764031 - Flags: review?(bobbyholley) → review+
Whiteboard: btpp-active
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60fb7c5abb3f
part 1.  Eliminate XPCCallContext's mCallerLanguage member.  r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/e304e87eebad
part 2.  Eliminate the unused XPCContext::CallerTypeIsNative/CallerTypeIsKnown methods.  r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc7b73290ba
part 3.  Drop the one place that uses XPCContext::CallerTypeIsJavaScript() (an assertion).  r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3da1bcf7194
part 4.  Get rid of XPCContext's mCallingLangType member.  r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/81fe29f830af
part 5.  Get rid of the LangType argument of the XPCCallContext constructor and the now-dead language type enums.  r=bholley
You need to log in before you can comment on or make changes to this bug.