Closed
Bug 1281299
Opened 8 years ago
Closed 8 years ago
IPv6 URLs crash in FaviconFetcher
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
STR: 1) Navigate to http://[::1]:6571/about/license. 2) Tap the URL bar to open overlay mode, then tap the URL bar again to edit the text. Proceed to crash in FaviconFetcher.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8764067 -
Flags: review?(sleroux)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8764067 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1925 Nice catch. I wouldn't be surprised if it's an iOS URL bug considering they were having issues with parsing RFP-valid URLs in iOS 8. I wonder if it's worth doing a range check as well where we crash in the case the domainURL returns nothing. Maybe it doesn't matter because this isn't a valid case?
Attachment #8764067 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Seems like a good idea. I can't think of other situations where this could happen, but it can't hurt!
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://github.com/mozilla/firefox-ios/commit/ef3481d1ae1c18ac60fb0106feda86ce1aff94e2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-fxios-v6.0:
--- → fixed
Resolution: --- → FIXED
|
|
||
Comment 5•8 years ago
|
||
v5.x 9cd74653fce0e7e30ab408f4ad6bafa1bae80a32
status-fxios-v5.0:
--- → fixed
|
|
Assignee | |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•