Mozilla has caught an Obj-C exception [NSBadBitmapParametersException: Overflow allocating bitmap backing store...]

RESOLVED FIXED in Firefox 50

Status

()

Core
ImageLib
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Jesse Ruderman, Assigned: lsalzman)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla50
assertion, testcase
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8764190 [details]
testcase

2016-06-22 03:17:27.024 firefox-bin[97888:419280] Mozilla has caught an Obj-C exception [NSBadBitmapParametersException: Overflow allocating bitmap backing store.  Cannot back bitmap with 34359738368 bytes per row, 8589934590 height, and 1 planes.]

See also bug 1230115, for when the size is large rather than negative.
(Reporter)

Comment 1

2 years ago
Created attachment 8764191 [details]
stack
(Assignee)

Comment 2

2 years ago
Created attachment 8764338 [details] [diff] [review]
ignore negative icon size in URI

mSize in nsMozIconURI is stored as a uint32_t, but we allow the input to come from an int. So if the input is negative, it will end up wrapping when stuffed into mSize. The prudent thing here seems to be to just ignore such negative values.
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Attachment #8764338 - Flags: review?(seth)
Comment on attachment 8764338 [details] [diff] [review]
ignore negative icon size in URI

Review of attachment 8764338 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good Lee!
Attachment #8764338 - Flags: review?(seth) → review+

Comment 4

2 years ago
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45fb2585696d
ignore negative icon size in URI. r=seth

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45fb2585696d
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.