Closed
Bug 1281436
Opened 9 years ago
Closed 9 years ago
Fixup MenuTests to be less brittle when adding new items
Categories
(Firefox for iOS :: Menu and Toolbar, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jhugman, Assigned: jhugman)
Details
Attachments
(1 file)
Following on from NoImageMode, and Homepage (Bug 1274617), MenuTests should be tolerant of other items being added to the menu.
The test should be testing the presence of absence of optional items based on state changes.
| Assignee | ||
Comment 1•9 years ago
|
||
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jhugman
| Assignee | ||
Updated•9 years ago
|
Attachment #8764215 -
Flags: review?(bmunar)
| Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8764215 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1928
LGTM - small nit i think
Attachment #8764215 -
Flags: review?(bmunar) → review+
| Assignee | ||
Comment 3•9 years ago
|
||
Merged into master.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•