[shipping] dashboard suggestion is open even if latest revision is rejected.

RESOLVED FIXED

Status

Webtools
Elmo
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

a year ago
The action on /shipping/dashboard is still 'sign off', even if the latest revision is rejected. Action turns out to be both.

Should just be rejected.

Comment 1

a year ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/e531e40dc5455f69bde031c33729c369183fcde0
bug 1281468, don't suggest new sign-offs if last push is rejected

The problem was that we tried to ignore fallbacks by looking
at current or pending sign-offs. Which made us ignore rejected
ones.

Fix is to explicitly ignore fallback actions, which are, by
def, ACCEPTED with a fallback appversion.
(Assignee)

Comment 2

a year ago
This is FIXED and in production.
Assignee: nobody → l10n
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.