Closed Bug 1281476 Opened 9 years ago Closed 9 years ago

TabManagerTests failing

Categories

(Firefox for iOS :: Build & Test, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Details

Attachments

(1 file)

48 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review
The current TabManagerTests (only testTabManagerStoresChangesInDB) are failing. It looks like the test is testing the wrong things after significant refactoring of the code it is testing. The test should be refactored out to better reflect the code being tested, and to be more of a unit test suite and less of an integration test suite
Attached file Pull request
Mocking FTW
Attachment #8764275 - Flags: review?(jhugman)
Comment on attachment 8764275 [details] [review] Pull request The first test needs a tiny change, but otherwise, looks good.
Attachment #8764275 - Flags: review?(jhugman) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: