1281479 - Rewrite references to git commits to point to github

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect, P1)

Description

[Dylan Hardison [:dylan] (he/him)]

git commits in comments should point to github.

It would be nice if references to git.mozilla.org could point to repos on github too, at least for bmo and upstream.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

For instance, while the display text should stay the same, https://git.mozilla.org/?p=webtools/bmo/bugzilla.git;a=blob;f=Bugzilla/WebService/Bug.pm;h=d7a1d8f9bb5fdee524f2bb342a4573a63d890f2e;hb=HEAD#l657 [github] should actually point to github.

Comment 2

[David Lawrence [:dkl]]

Attachment: 1281479_1.patch

This just does commit comments currently. I will need to do some thought on the general changing of links as the params can vary and we will need to massage the params into proper path for github so line numbers work, etc.

dkl

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8764748 [details] [diff] [review]
1281479_1.patch

Review of attachment 8764748 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
f+

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8764748 [details] [diff] [review]
1281479_1.patch

Will do the second part as a separate bug.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8764748 [details] [diff] [review]
1281479_1.patch

Review of attachment 8764748 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

sorry about that.

Comment 6

[David Lawrence [:dkl]]

To https://github.com/mozilla-bteam/bmo.git
   557410f..e0ab472  master -> master