Closed Bug 1281479 Opened 4 years ago Closed 4 years ago

Rewrite references to git commits to point to github

Categories

(bugzilla.mozilla.org :: General, defect, P1)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dkl)

References

Details

Attachments

(1 file)

git commits in comments should point to github.

It would be nice if references to git.mozilla.org could point to repos on github too, at least for bmo and upstream.
Depends on: 1281481
No longer blocks: 1281478
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attached patch 1281479_1.patchSplinter Review
This just does commit comments currently. I will need to do some thought on the general changing of links as the params can vary and we will need to massage the params into proper path for github so line numbers work, etc.

dkl
Attachment #8764748 - Flags: feedback?(dylan)
Comment on attachment 8764748 [details] [diff] [review]
1281479_1.patch

Review of attachment 8764748 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
f+
Attachment #8764748 - Flags: feedback?(dylan) → feedback+
Blocks: 1281481
No longer depends on: 1281481
Comment on attachment 8764748 [details] [diff] [review]
1281479_1.patch

Will do the second part as a separate bug.
Attachment #8764748 - Flags: feedback+ → review?(dylan)
Comment on attachment 8764748 [details] [diff] [review]
1281479_1.patch

Review of attachment 8764748 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

sorry about that.
Attachment #8764748 - Flags: review?(dylan) → review+
To https://github.com/mozilla-bteam/bmo.git
   557410f..e0ab472  master -> master
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.