1281502 - Improve localization comments for Code Editor shortcuts

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[Francesco Lodolo [:flod]]

Several strings have key identifiers that should not be localized, but there's no localization comment indicating that.
https://hg.mozilla.org/releases/mozilla-aurora/file/default/devtools/client/locales/en-US/sourceeditor.properties#l87

Shortcuts are then passed to CodeMirror and fail (see for example bug 1147357)
https://codemirror.net/doc/manual.html#keymaps

Comment 1

[Francesco Lodolo [:flod]]

Attachment: bug1281502.patch

Hi Panos, Bugzilla is suggesting you as a reviewer, not sure if that's a glitch in the matrix :-)

Do you mind double checking this?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8764561 [details] [diff] [review]
bug1281502.patch

Review of attachment 8764561 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense. For future reference bgrins or fitzgen would be better reviewers for anything related to the source editor component.

Comment 3

[Francesco Lodolo [:flod]]

Thanks. I'm not completely sure where Bugzilla gets his "Suggested reviewers", and if that can be fixed upstream.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/a7e793ef71a3
Improve localization comments for Source Editor shortcuts. r=past

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a7e793ef71a3