1281547 - compatibility check should log the reason for failure

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Helmer [:rhelmer]]

The isUsableAddon function in XPIProvider.jsm can fail for several reasons, but there is no logging so it's basically impossible to tell quickly what the problem is for an add-on developer.

This would have helped us get to the bottom of bug 1273547 faster, but this is not the first time I have run across this.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: Bug 1281547 - add-on compatibility check should log underlying reason

Review commit: https://reviewboard.mozilla.org/r/60292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60292/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8764341 [details]
Bug 1281547 - add-on compatibility check should log underlying reason

https://reviewboard.mozilla.org/r/60292/#review57338

Looks good with one minor suggestion: include the addon id in the log messages.  If somebody doesn't happen to see the log message at the moment an addon is being installed or enabled, it might be unclear where the message came from and having the id would help.

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 8764341 [details]
Bug 1281547 - add-on compatibility check should log underlying reason

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60292/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f046ea5bb4d
add-on compatibility check should log underlying reason r=aswan

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8f046ea5bb4d