Closed
Bug 1281582
Opened 8 years ago
Closed 8 years ago
Remove JSContext privates (first and second)
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
3.94 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Once bug 1276310 lands, Gecko will no longer use them.
|
Assignee | |
Comment 1•8 years ago
|
||
efaust pointed out other embeddings may care.
Flags: needinfo?(jorendorff)
|
||
Comment 2•8 years ago
|
||
There's still the runtime private (which will be renamed back to GetContextPrivate at some point), that embedders can use, so IMO it'd be best to remove it now that we're overhauling the context/runtime APIs...
|
||
Comment 3•8 years ago
|
||
We should remove this and, in release notes, tell embedders that this is part of our plans to merge JSContext and JSRuntime, and that they should switch to global variables or thread-local storage.
Flags: needinfo?(jorendorff)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8764469 -
Flags: review?(jorendorff)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8764469 [details] [diff] [review] Remove JSContext privates Review of attachment 8764469 [details] [diff] [review]: ----------------------------------------------------------------- Thank you.
Attachment #8764469 -
Flags: review?(jorendorff) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/423d7e86c526 Remove JSContext privates. r=jorendorff
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/423d7e86c526
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•