1281616 - Buttons cut off on confirmCheck prompt if checkbox text wraps

Status: NEW

(Toolkit :: UI Widgets, defect, P3)

Description

[Mike Kaply [:mkaply]]

Attachment: Multiple language screenshot

The confirm close all tabs dialog is cut off at the bottom in multiple languages.

See attachment.

Comment 1

[Mike Kaply [:mkaply]]

This is on a Windows 10 machine at 3840x2160 with the text resolution at 150% (Microsoft recommended).

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I have seen this with other modal dialogs. I will try to get a screenshot next time I see it. I believe it's the same bug.

mkaply, do you know how to use mozregression with a different locale build? If we know what regressed this we'll be able to fix it much faster.

Comment 3

[Mike Kaply [:mkaply]]

> mkaply, do you know how to use mozregression with a different locale build? If we know what regressed this we'll be able to fix it much faster.

I can take a look. Do we know for sure it is a regression?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

I hope it is and that we haven't been shipping that since the beginning of time :)

Thanks for taking a look!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Mike, were you able to run mozregresion on this?

Comment 6

[Mike Kaply [:mkaply]]

Not yet, but is on my todo list. Sorry.

Comment 7

[Mike Kaply [:mkaply]]

There does not appear to be a way to do bisection of locale specific builds...

Comment 8

[Mike Kaply [:mkaply]]

I missed the obvious commonality among all these dialogs - wrapped checkbox.

To recreate this on English, use this in a browser scratch pad:

var prompts = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
                        .getService(Components.interfaces.nsIPromptService);

var check = {value: true};                   // default the checkbox to true

var result = prompts.confirmCheck(null, "Title of this Dialog", "Are you sure?",
                                  "Don't ask again (Really long to see if it cuts off the buttons . No really.)", check);

Comment 9

[Mike Kaply [:mkaply]]

Attachment: No wrapping on low res

On a low DPI screen, the checkbox never wraps.

So that's the difference here. On Hi res, we're wrapping the checkbox. On low res we are not.

Comment 10

[Mike Kaply [:mkaply]]

Sorry, one more comment. On hi res, it doesn't wrap either with very long text. It only wraps if you are a few words over the initial width.

Comment 11

[Mike Kaply [:mkaply]]

This appears to be a rounding error. You only ever see one word wrap, and it only happens on 150% or greater Windows displays.

To see this problem, run this in the browser scratch pad. Every one or two times you'll see one word wrap.

var prompts = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
                        .getService(Components.interfaces.nsIPromptService);

var check = {value: true};                   // default the checkbox to true

var text = "Word";

for (var i=0; i < 50; i++) {
  text = text + " Word";

  var result = prompts.confirmCheck(null, "Title of this Dialog", "Are you sure?",
                                    text, check);
}

Comment 12

[Mike Kaply [:mkaply]]

The same rounding error exists on Mac, only it shifts the buttons down. You don't want to run the loop 50 times on Mac, though, it's slow as molasses.

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.