1281618 - globalgen_sources and unified_binding_cpp_files should be handled in moz.build

Status: NEW

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

We still have the following TODO in dom/bindings/Makefile.in:

# These come from webidlsrcs.mk.
# TODO Write directly into backend.mk.
CPPSRCS += $(globalgen_sources) $(unified_binding_cpp_files)

Since moz.build generates webidlsrcs.mk anyway, it should be able to write out the necessary info into the backend directory rather than relying on this in the Makefile.

Comment 1

[Nathan Froyd [:froydnj]]

I will look at this.  Need to make it look like I still understand the build system. ;)

Comment 2

[Chris Manchester (limited bugmail, email directly)]

I don't actually think this is a blocker for tup... the tup backend knows about all the sources from within its _handle_webidl_build method, can't it just emit its own rules for building those independently from the make backend?

Comment 3

[Michael Shal [:mshal]]

(In reply to Chris Manchester (:chmanchester) from comment #2)
> I don't actually think this is a blocker for tup... the tup backend knows
> about all the sources from within its _handle_webidl_build method, can't it
> just emit its own rules for building those independently from the make
> backend?

Yeah, I think you're right. I guess like the other one-offs in the build system (xpidl, ipdl, etc), it's more of a question of how much we intend to share between backends vs. how much needs to be re-implemented because it's a different backend. It seems like we have enough info in that method to begin compiling in tup.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.