Closed
Bug 1281619
Opened 7 years ago
Closed 7 years ago
Land version 1.4.1 of the Loop system add-on in mozilla-central
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox48 fixed, firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
mozilla50
People
(Reporter: standard8, Assigned: standard8)
References
()
Details
(Whiteboard: [btpp-fix-now])
Attachments
(2 files)
1.01 MB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1.03 MB,
patch
|
Sylvestre
:
approval-mozilla-release-
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8764390 -
Flags: review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/f3ec3e747ff9 Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.
Assignee | ||
Comment 3•7 years ago
|
||
Summary of release: - Improved metrics around connections (bug 1281252) for better diagnosis. - Removed unused telemetry histograms (bug 1275088) - Removed various obsolete code - Updated mocha and react libraries
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f3ec3e747ff9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8764390 [details] [diff] [review] Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code. Approval Request Comment [Feature/regressing bug #]: Firefox Hello - metrics improvements [User impact if declined]: This release is mainly to give us an additional data point so that we can tell if WebRTC conversations that don't complete successfully actually managed to complete connection - this will help with diagnosis for the actual cause of current issues. [Describe test coverage new/current, TreeHerder]: Has unit & integration tests, landed in m-c. [Risks and why]: Low, mainly code removals, a couple of fixes, and an additional bit of logging for improveming metrics. [String/UUID change made/needed]: None
Attachment #8764390 -
Flags: approval-mozilla-beta?
Attachment #8764390 -
Flags: approval-mozilla-aurora?
Updated•7 years ago
|
status-firefox48:
--- → affected
status-firefox49:
--- → affected
Comment 6•7 years ago
|
||
Comment on attachment 8764390 [details] [diff] [review] Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code. Update Hello, taking it. Should be in 48 beta 4
Attachment #8764390 -
Flags: approval-mozilla-beta?
Attachment #8764390 -
Flags: approval-mozilla-beta+
Attachment #8764390 -
Flags: approval-mozilla-aurora?
Attachment #8764390 -
Flags: approval-mozilla-aurora+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/0e888cae95ca
Comment 8•7 years ago
|
||
has problems uplifting to beta: grafting 351464:0e888cae95ca "Bug 1281619 - Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code. a=sylvestre" merging browser/extensions/loop/chrome/content/panels/css/desktop.css merging browser/extensions/loop/chrome/content/shared/css/common.css merging browser/extensions/loop/chrome/content/shared/js/activeRoomStore.js merging browser/extensions/loop/chrome/content/shared/test/activeRoomStore_test.js merging browser/extensions/loop/chrome/test/mochitest/browser.ini merging browser/extensions/loop/test/functional/manifest.ini warning: conflicts while merging browser/extensions/loop/chrome/content/panels/css/desktop.css! (edit, then use 'hg resolve --mark') warning: conflicts while merging browser/extensions/loop/test/functional/manifest.ini! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(standard8)
Assignee | ||
Comment 9•7 years ago
|
||
Fixed, a few bits of simple bitrot caused by tree-wide changes: https://hg.mozilla.org/releases/mozilla-beta/rev/b98e6837de52c839aa3f2a222c70c53038c63527
Flags: needinfo?(standard8)
Assignee | ||
Comment 10•7 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Firefox Hello. This is part of the Firefox Hello 1.4.2 system add-on update that shipped to 47.0.1 users (along with bug 1273671 and bug 1282899). It should be landed in release should there be another dot release, so that users get the correct version of the add-on.
Attachment #8771389 -
Flags: approval-mozilla-release?
Assignee | ||
Updated•7 years ago
|
Attachment #8771389 -
Attachment is patch: true
Comment 11•7 years ago
|
||
Comment on attachment 8771389 [details] [diff] [review] mozilla-release version Don't think we will do a dot release of 47
Attachment #8771389 -
Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•