1281619 - Land version 1.4.1 of the Loop system add-on in mozilla-central

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Changelog: https://github.com/mozilla/loop/blob/release/CHANGELOG.md

Comment 1

[Mark Banner (:standard8)]

Attachment: Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/f3ec3e747ff9
Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Comment 3

[Mark Banner (:standard8)]

Summary of release:

- Improved metrics around connections (bug 1281252) for better diagnosis.
- Removed unused telemetry histograms (bug 1275088)
- Removed various obsolete code
- Updated mocha and react libraries

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3ec3e747ff9

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8764390 [details] [diff] [review]
Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello - metrics improvements
[User impact if declined]: This release is mainly to give us an additional data point so that we can tell if WebRTC conversations that don't complete successfully actually managed to complete connection - this will help with diagnosis for the actual cause of current issues.
[Describe test coverage new/current, TreeHerder]: Has unit & integration tests, landed in m-c.
[Risks and why]: Low, mainly code removals, a couple of fixes, and an additional bit of logging for improveming metrics.
[String/UUID change made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8764390 [details] [diff] [review]
Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Update Hello, taking it.
Should be in 48 beta 4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0e888cae95ca

Comment 8

[Carsten Book [:Tomcat]]

has problems uplifting to beta:

grafting 351464:0e888cae95ca "Bug 1281619 - Land version 1.4.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code. a=sylvestre"
merging browser/extensions/loop/chrome/content/panels/css/desktop.css
merging browser/extensions/loop/chrome/content/shared/css/common.css
merging browser/extensions/loop/chrome/content/shared/js/activeRoomStore.js
merging browser/extensions/loop/chrome/content/shared/test/activeRoomStore_test.js
merging browser/extensions/loop/chrome/test/mochitest/browser.ini
merging browser/extensions/loop/test/functional/manifest.ini
warning: conflicts while merging browser/extensions/loop/chrome/content/panels/css/desktop.css! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/extensions/loop/test/functional/manifest.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 9

[Mark Banner (:standard8)]

Fixed, a few bits of simple bitrot caused by tree-wide changes:

https://hg.mozilla.org/releases/mozilla-beta/rev/b98e6837de52c839aa3f2a222c70c53038c63527

Comment 10

[Mark Banner (:standard8)]

Attachment: mozilla-release version

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello.

This is part of the Firefox Hello 1.4.2 system add-on update that shipped to 47.0.1 users (along with bug 1273671 and bug 1282899).

It should be landed in release should there be another dot release, so that users get the correct version of the add-on.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8771389 [details] [diff] [review]
mozilla-release version

Don't think we will do a dot release of 47