1281627 - Can no longer have both --enable-debug and --enable-debug-symbols

Status: NEW

(Firefox Build System :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This used to work; I have --enable-debug-symbols in the overall mozconfig that both debug and opt builds use...

Now I get:

mozbuild.configure.options.InvalidOptionError: '--enable-debug-symbols=-gdwarf-2' implied by '--enable-debug' conflicts with '--enable-debug-symbols' from the mozconfig

Comment 1

[Chris Manchester (limited bugmail, email directly)]

That error message means this is a mozconfig with

ac_add_options --enable-debug-symbols
ac_add_options --enable-debug=-gdwarf-2

This was intended with bug 1279369, because --enable-debug-symbols has no effect in this case. In the case --enable-debug isn't set, --enable-debug-symbols is the default.

An earlier version of that patch emulated the existing behavior, I can post that here if we want to go back to it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.

So my use case is that I basically have three mozconfigs: opt, debug, shared.  The first two both include the third.  I want debug symbols in all, so have --enable-debug-symbols in the shared.  I don't know at this point why I have the -gdwarf-2 thing.

Without the --enable-debug thing, is there a difference between --enable-debug-symbols and --enable-debug-symbols=-gdwarf-2?

For that matter, is there a practical difference between "--enable-debug=-gdwarf-2" and "--enable-debug --enable-debug-symbols"?

I'm pretty happy to change my mozconfigs here; I just want to make sure that both my debug and opt builds end up with the best debug symbols I can get, without sacrificing performance of the opt build.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

I think the thing to do will be to remove --enable-debug-symbols altogether. This is the default, so the opt builds will still end up with symbols (via "-g"), and debug builds will use whatever is passed to --enable-debug.

I'm not sure of the practical differences between "-g" (the default) and "-gdwarf-2", but DWARF seems like a common default for debug info.

Comment 4

[Boris Zbarsky [:bzbarsky]]

OK.  Can probably just mark this invalid then...