1281676 - |make uploadsymbols| busted due to objdir being referenced as under build/mozilla

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

/builds/slave/c-cen-t-lnx-ntly/build/objdir/_virtualenv/bin/python -u /builds/slave/c-cen-t-lnx-ntly/build/mozilla/toolkit/crashreporter/tools/upload_symbols.py 'dist/seamonkey-2.47a1.en-US.linux-i686.crashreporter-symbols-full.zip'
Traceback (most recent call last):
  File "/builds/slave/c-cen-t-lnx-ntly/build/mozilla/toolkit/crashreporter/tools/upload_symbols.py", line 23, in <module>
    from buildconfig import substs
  File "/builds/slave/c-cen-t-lnx-ntly/build/mozilla/build/mach_bootstrap.py", line 380, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "/builds/slave/c-cen-t-lnx-ntly/build/mozilla/build/buildconfig.py", line 9, in <module>
    config = MozbuildObject.from_environment()
  File "/builds/slave/c-cen-t-lnx-ntly/build/mozilla/python/mozbuild/mozbuild/base.py", line 184, in from_environment
    if not samepath(topobjdir, _config_topobjdir):
  File "/builds/slave/c-cen-t-lnx-ntly/build/mozilla/python/mozbuild/mozbuild/base.py", line 46, in samepath
    return os.path.samefile(path1, path2)
  File "/builds/slave/c-cen-t-lnx-ntly/build/objdir/_virtualenv/lib/python2.7/posixpath.py", line 163, in samefile
    s2 = os.stat(f2)
OSError: [Errno 2] No such file or directory: '/builds/slave/c-cen-t-lnx-ntly/build/mozilla/objdir'
make: *** [uploadsymbols] Error 1
retry: Failed, sleeping 1 seconds before retrying
retry: Calling <function run_with_timeout at 0x2411050> with args: (['make', 'uploadsymbols'], 2460, None, None, False, True), kwargs: {}, attempt #2
Executing: ['make', 'uploadsymbols']

Comment 1

[Edmund Wong (:ewong)]

Attachment: bug_1281676.diff [checked-in]

Comment 2

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbotcustom/rev/e9c9fa32129cb9851eebd0799c70a1122e88e8de
Bug 1281676 - Add MOZ_OBJDIR to uploadsymbols env.

Comment 3

[Edmund Wong (:ewong)]

Comment on attachment 8764444 [details] [diff] [review]
bug_1281676.diff [checked-in]

Pushed to buildbotcustom:
https://hg.mozilla.org/build/buildbotcustom/rev/e9c9fa32129c

(post-land-review)

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 8764444 [details] [diff] [review]
bug_1281676.diff [checked-in]

As per Callek's approval on irc, I'm closing bugs that have patches which have been pushed already.