1281717 - Gaia lint regressed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=pine&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=33832

> Makefile:1006: recipe for target 'hint' failed
> make[1]: *** [hint] Error 1
> error in apps/dialer/style/lockscreen.css
>     Expected RPAREN at line 156, col 11. at:-moz-any(.touched, #screen:not(.locked), #screen.attention, #lockscreen:not([data-panel="main"]))
> warning in apps/dialer/style/oncall.css
>    Too many font-size declarations (17), abstraction needed. a tundefined
> make[1]: Leaving directory '/home/alex/codaz/Mozilla/b2g/gaia'
> Makefile:992: recipe for target 'lint' failed
> make: *** [lint] Error 2

Comment 1

[:gerard-majax]

There is an error about .jshintrc (while running jshint) that I had reproduced locally but that went away after a |make clean really-clean && make -k hint jsonlint csslint|:
> [31mERROR[0m: Can't find config file: /home/worker/workspace/.jshintrc

How can we fix this ? The csslint issue can be fixed after I guess :/

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

I can repro locally, looking into this.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

I've figured it out, it's an issue with the dialer, fix incoming.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1281717-fix-linter > mozilla-b2g:kanikani

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8764555 [details] [review]
[gaia] gabrielesvelto:bug-1281717-fix-linter > mozilla-b2g:kanikani

Quick fix, also fix

Comment 6

[:gerard-majax]

\o/

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8764555 [details] [review]
[gaia] gabrielesvelto:bug-1281717-fix-linter > mozilla-b2g:kanikani

LGTM, Thanks!

Comment 8

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/d1e0f3f5ff6dbbbfecbcdbdea50d87bdc4688f98

Comment 9

[:gerard-majax]

Attachment: Bump gaia revision

Comment 10

[:gerard-majax]

https://hg.mozilla.org/projects/pine/rev/69c59a07a6d4